From mboxrd@z Thu Jan 1 00:00:00 1970 From: Balbir Singh Subject: Re: [PATCH][for -mm] Fix and Enhancements for memory cgroup [2/6] fix err handling in charging Date: Tue, 09 Oct 2007 16:18:08 +0530 Message-ID: <470B5C68.2070800@linux.vnet.ibm.com> References: <20071009184620.8b14cbc6.kamezawa.hiroyu@jp.fujitsu.com> <20071009185018.4d279d07.kamezawa.hiroyu@jp.fujitsu.com> Reply-To: balbir-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20071009185018.4d279d07.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: KAMEZAWA Hiroyuki Cc: "containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org" , "linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org" , Andrew Morton List-Id: containers.vger.kernel.org KAMEZAWA Hiroyuki wrote: > This unlock_page_cgroup() is unnecessary. > > Signed-off-by: KAMEZAWA Hiroyuki > > > mm/memcontrol.c | 2 -- > 1 file changed, 2 deletions(-) > > Index: linux-2.6.23-rc8-mm2/mm/memcontrol.c > =================================================================== > --- linux-2.6.23-rc8-mm2.orig/mm/memcontrol.c > +++ linux-2.6.23-rc8-mm2/mm/memcontrol.c > @@ -381,9 +381,7 @@ done: > return 0; > free_pc: > kfree(pc); > - return -ENOMEM; > err: > - unlock_page_cgroup(page); > return -ENOMEM; > } > > Looks good to me Acked-by: Balbir Singh -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL