From mboxrd@z Thu Jan 1 00:00:00 1970 From: Balbir Singh Subject: Re: [PATCH][BUGFIX][for -mm] Misc fix for memory cgroup [4/5] skip !PageLRU page in mem_cgroup_isolate_pages Date: Tue, 30 Oct 2007 11:30:43 +0530 Message-ID: <4726C88B.1030109@linux.vnet.ibm.com> References: <20071011135345.5d9a4c06.kamezawa.hiroyu@jp.fujitsu.com> <20071011140115.173d1a9d.kamezawa.hiroyu@jp.fujitsu.com> <20071030144745.1af1cbde.kamezawa.hiroyu@jp.fujitsu.com> Reply-To: balbir-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20071030144745.1af1cbde.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: KAMEZAWA Hiroyuki Cc: "containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org" , "linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org" , Andrew Morton List-Id: containers.vger.kernel.org KAMEZAWA Hiroyuki wrote: > I'm sorry that this patch needs following fix.. > Andrew, could you apply this ? > (All version I sent has this bug....Sigh) > > Thanks, > -Kame > == > Bugfix for memory cgroup skip !PageLRU page in mem_cgroup_isolate_pages > > Signed-off-by: KAMEZAWA Hiroyuki > > Index: devel-2.6.23-mm1/mm/memcontrol.c > =================================================================== > --- devel-2.6.23-mm1.orig/mm/memcontrol.c > +++ devel-2.6.23-mm1/mm/memcontrol.c > @@ -260,7 +260,7 @@ unsigned long mem_cgroup_isolate_pages(u > spin_lock(&mem_cont->lru_lock); > scan = 0; > list_for_each_entry_safe_reverse(pc, tmp, src, lru) { > - if (scan++ > nr_taken) > + if (scan++ > nr_to_scan) > break; > page = pc->page; > VM_BUG_ON(!pc); > Good catch! Sorry, I missed it in the review Acked-by: Balbir Singh -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL