From mboxrd@z Thu Jan 1 00:00:00 1970 From: Balbir Singh Subject: Re: [RFC][for -mm] memory controller enhancements for reclaiming take2 [2/8] add BUG_ON() in mem_cgroup_zoneinfo Date: Tue, 04 Dec 2007 21:31:32 +0530 Message-ID: <475579DC.6020006@linux.vnet.ibm.com> References: <20071203183355.0061ddeb.kamezawa.hiroyu@jp.fujitsu.com> <20071203183639.48a4b1f3.kamezawa.hiroyu@jp.fujitsu.com> Reply-To: balbir-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20071203183639.48a4b1f3.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: KAMEZAWA Hiroyuki Cc: "riel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" , "yamamoto-jCdQPDEk3idL9jVzuh4AOg@public.gmane.org" , "linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org" , "containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org" , Andrew Morton , xemul-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org List-Id: containers.vger.kernel.org KAMEZAWA Hiroyuki wrote: > This should be BUG_ON(). I misunderstood initialization path. > > Signed-off-by: KAMEZAWA Hiroyuki > > mm/memcontrol.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > Index: linux-2.6.24-rc3-mm2/mm/memcontrol.c > =================================================================== > --- linux-2.6.24-rc3-mm2.orig/mm/memcontrol.c > +++ linux-2.6.24-rc3-mm2/mm/memcontrol.c > @@ -206,8 +206,7 @@ static void mem_cgroup_charge_statistics > static inline struct mem_cgroup_per_zone * > mem_cgroup_zoneinfo(struct mem_cgroup *mem, int nid, int zid) > { > - if (!mem->info.nodeinfo[nid]) > - return NULL; > + BUG_ON(!mem->info.nodeinfo[nid]); > return &mem->info.nodeinfo[nid]->zoneinfo[zid]; > } > > Acked-by: Balbir Singh -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL