From: Pavel Emelyanov <xemul-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
To: Daniel Hokka Zakrisson <daniel-nym3zxDgnZcAvxtiuMwx3w@public.gmane.org>
Cc: Linux Containers
<containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>,
Cedric Le Goater <clg-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] An attempt to have an unlimitedly extendable sys_clone
Date: Wed, 16 Jan 2008 11:09:06 +0300 [thread overview]
Message-ID: <478DBBA2.6080202@openvz.org> (raw)
In-Reply-To: <41572.192.168.102.6.1200470331.squirrel@intranet>
Daniel Hokka Zakrisson wrote:
> Pavel Emelyanov wrote:
>> [snip]
>>
>>>> +static struct long_clone_arg *get_long_clone_arg(int __user
>>>> *child_tidptr)
>>>> +{
>>>> + int size;
>>>> + struct long_clone_arg *carg;
>>>> +
>>>> + if (get_user(size, child_tidptr))
>>>> + return ERR_PTR(-EFAULT);
>>>> +
>>>> + if (size > sizeof(struct long_clone_arg))
>>>> + return ERR_PTR(-EINVAL);
>>> This means that software built against a newer kernel won't work on an
>>> older one. Surely that's not intended?
>> It is intended. If I ask an old kernel to clone the mq namespace, but
>> it doesn't support such, that I'd better like to get an -EINVAL error
>> rather than be silently held in an old global namespace.
>
> That rules out using the struct for things like child_tidptr, the desired
> pid for C/R, etc. I think the version Dave Hansen proposed would be
A new system call? Ok - what arguments should it take?
> better, or if it's really just for bits, use an array rather than a struct
> to make that obvious.
It's for anything you'd like to tell to clone(). In the nearest future - for
more bits to clone new namespaces. In the far future - for pid to create the
task with (for c/r jobs). In the the far-far future - for anything you will
need then.
>> [snip]
>>
>
next prev parent reply other threads:[~2008-01-16 8:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-15 12:50 [PATCH] An attempt to have an unlimitedly extendable sys_clone Pavel Emelyanov
[not found] ` <478CAC32.4080809-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
2008-01-15 13:38 ` Cedric Le Goater
[not found] ` <478CB73E.30603-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
2008-01-15 14:48 ` Cedric Le Goater
[not found] ` <478CC7AD.7060908-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
2008-01-15 21:40 ` Serge E. Hallyn
2008-01-16 7:39 ` Pavel Emelyanov
[not found] ` <478DB4CC.1090102-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
2008-01-16 8:15 ` Cedric Le Goater
2008-01-21 10:36 ` Cedric Le Goater
2008-01-15 13:52 ` Cedric Le Goater
2008-01-15 14:34 ` Daniel Hokka Zakrisson
2008-01-15 21:46 ` Serge E. Hallyn
2008-01-16 7:26 ` Pavel Emelyanov
[not found] ` <478DB1AC.6050508-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
2008-01-16 7:58 ` Daniel Hokka Zakrisson
2008-01-16 8:07 ` Daniel Hokka Zakrisson
2008-01-16 8:09 ` Pavel Emelyanov [this message]
2008-01-16 17:52 ` Dave Hansen
2008-01-15 15:17 ` Oren Laadan
[not found] ` <478CCE81.5090605-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2008-01-15 15:56 ` Cedric Le Goater
2008-01-16 7:37 ` Pavel Emelyanov
2008-01-15 17:54 ` Dave Hansen
2008-01-15 21:32 ` Serge E. Hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=478DBBA2.6080202@openvz.org \
--to=xemul-gefaqzzx7r8dnm+yrofe0a@public.gmane.org \
--cc=clg-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org \
--cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
--cc=daniel-nym3zxDgnZcAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox