Linux Container Development
 help / color / mirror / Atom feed
From: Daisuke Nishimura <nishimura-YQH0OdQVrdy45+QrQBaojngSJqDPrsil@public.gmane.org>
To: KAMEZAWA Hiroyuki
	<kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org,
	linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
	xemul-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org,
	hugh-DTz5qymZ9yRBDgjK7y7TUQ@public.gmane.org,
	balbir-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org
Subject: Re: [RFC/PATCH] cgroup swap subsystem
Date: Thu, 06 Mar 2008 20:45:27 +0900	[thread overview]
Message-ID: <47CFD957.3060402@mxp.nes.nec.co.jp> (raw)
In-Reply-To: <20080305155329.60e02f48.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>

Hi.

> At first look, remembering mm struct is not very good.
> Remembering swap controller itself is better.

The swap_cgroup when the page(and page_cgroup) is allocated and
the swap_cgroup when the page is going to be swapped out may be
different by swap_cgroup_move_task(), so I think swap_cgroup
to be charged should be determined at the point of swapout.

Instead of pointing mm_struct from page_cgroup, it would be
better to determine the mm_struct which the page to be swapped
out is belongs to by rmap, and charge swap_cgroup of the mm_struct.
In this implementation, I don't need to add new member to page_cgroup.

What do you think ?


Thanks,
Daisuke Nishimura.

  parent reply	other threads:[~2008-03-06 11:45 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-05  5:59 [RFC/PATCH] cgroup swap subsystem Daisuke Nishimura
     [not found] ` <47CE36A9.3060204-YQH0OdQVrdy45+QrQBaojngSJqDPrsil@public.gmane.org>
2008-03-05  6:36   ` Paul Menage
     [not found]     ` <6599ad830803042236x3e5fdf0dmaf4119997025ba40-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-03-06 12:20       ` Daisuke Nishimura
2008-03-05  6:53   ` KAMEZAWA Hiroyuki
     [not found]     ` <20080305155329.60e02f48.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2008-03-05 21:51       ` Hirokazu Takahashi
2008-03-06 11:45       ` Daisuke Nishimura [this message]
     [not found]         ` <47CFD957.3060402-YQH0OdQVrdy45+QrQBaojngSJqDPrsil@public.gmane.org>
2008-03-06 12:25           ` Pavel Emelyanov
2008-03-06 12:56           ` kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A
     [not found]             ` <6197904.1204808216900.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2008-03-07  8:22               ` Daisuke Nishimura
2008-03-12 22:57               ` YAMAMOTO Takashi
2008-03-05  7:03   ` KAMEZAWA Hiroyuki
2008-03-05  7:28   ` Balbir Singh
     [not found]     ` <47CE4BB6.8050803-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2008-03-07  4:23       ` Daisuke Nishimura
2008-03-05  8:33   ` Pavel Emelyanov
     [not found]     ` <47CE5AE2.2050303-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
2008-03-05  8:51       ` Daisuke Nishimura
2008-03-05 14:07       ` Hugh Dickins
     [not found]         ` <Pine.LNX.4.64.0803051400000.22243-popGQ1T0qN76K7/ahGyk6A@public.gmane.org>
2008-03-05 14:14           ` Pavel Emelyanov
     [not found]             ` <47CEAAB4.8070208-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
2008-03-06  0:33               ` KAMEZAWA Hiroyuki
     [not found]                 ` <20080306093324.77c6d7f4.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2008-03-06  0:35                   ` Paul Menage
2008-03-06  8:20                   ` Pavel Emelyanov
     [not found]                     ` <47CFA941.4070507-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
2008-03-06  8:33                       ` KAMEZAWA Hiroyuki
     [not found]                         ` <20080306173347.f6c5c84c.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2008-03-06  8:38                           ` Pavel Emelyanov
     [not found]                             ` <47CFAD69.6000909-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
2008-03-06  8:48                               ` [Devel] " Paul Menage
     [not found]                                 ` <6599ad830803060048sb39735an765a62e6b928657e-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-03-06  8:50                                   ` Pavel Emelyanov
     [not found]                                     ` <47CFB065.3080200-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
2008-03-06  8:52                                       ` Paul Menage

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47CFD957.3060402@mxp.nes.nec.co.jp \
    --to=nishimura-yqh0odqvrdy45+qrqbaojngsjqdprsil@public.gmane.org \
    --cc=balbir-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
    --cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
    --cc=hugh-DTz5qymZ9yRBDgjK7y7TUQ@public.gmane.org \
    --cc=kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org \
    --cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
    --cc=xemul-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox