From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Subject: Re: Multiple instances of devpts Date: Sat, 12 Apr 2008 12:30:05 -0700 Message-ID: <48010DBD.6010903@zytor.com> References: <20080412172933.GA19295@us.ibm.com> <20080412183514.GO9785@ZenIV.linux.org.uk> <48010583.3020403@zytor.com> <1208027757.28187.25.camel@x61.ebiederm.org> <48010C70.2030902@zytor.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <48010C70.2030902-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: "Eric W. Biederman" Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Al Viro , Containers , Linus Torvalds , Pavel Emelyanov List-Id: containers.vger.kernel.org H. Peter Anvin wrote: > > Thinking about it further, allowing this restriction would also allow a > whole lot of cleanups inside the pty setup, since it would eliminate the > need to do a separate lookup to find the corresponding devpts entry in > pty_open(). The benefit here comes from the closer coupling between the > pty and the devpts filesystem and isn't at all related to namespaces, > but it's a very nice side benefit. > Minor correction: the lookup is actually in init_dev() in tty_io.c; I'm specifically referring to devpts_get_tty(). -hpa