Linux Container Development
 help / color / mirror / Atom feed
From: Daniel Lezcano <dlezcano-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
To: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: Linux Containers
	<containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>,
	"Eric W. Biederman"
	<ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>,
	Benjamin Thery <benjamin.thery-6ktuUTfB/bM@public.gmane.org>
Subject: Re: sysfs : fix kobject rename with multiple namespaces
Date: Mon, 05 May 2008 19:05:57 +0200	[thread overview]
Message-ID: <481F3E75.5030806@fr.ibm.com> (raw)
In-Reply-To: <20080505165614.GA14956-6s5zFf/epYLPQpwDFJZrxKsjOiXwFzmk@public.gmane.org>

Serge E. Hallyn wrote:
  > The patch looks good to me, except I'd really rename this to
> 'sysfs_tag_eq'.  Calling it 'cmp', returning 't1!=t2', then checking for
> !sysfs_tag_cmp really increases the amount of thinking i have to do to
> make sure everything is koshepillager :)
> 
> Maybe it's just me.

I just wanted to have sysfs_tag_cmp returning zero when sysfs is 
disabled in order to be consistent with other functions.

But if that hurts, I can change that to something more mindless.

Thanks for looking at the patch.

   -- Daniel

      parent reply	other threads:[~2008-05-05 17:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-04 23:17 sysfs : fix kobject rename with multiple namespaces Daniel Lezcano
     [not found] ` <481E43FF.9070905-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
2008-05-05 16:56   ` Serge E. Hallyn
     [not found]     ` <20080505165614.GA14956-6s5zFf/epYLPQpwDFJZrxKsjOiXwFzmk@public.gmane.org>
2008-05-05 17:05       ` Daniel Lezcano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=481F3E75.5030806@fr.ibm.com \
    --to=dlezcano-nmtc/0zbporqt0dzr+alfa@public.gmane.org \
    --cc=benjamin.thery-6ktuUTfB/bM@public.gmane.org \
    --cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
    --cc=ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
    --cc=serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox