From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oren Laadan Subject: Re: [RFC v14-rc][PATCH 07/23] Restore memory address space Date: Sun, 22 Mar 2009 17:51:50 -0400 Message-ID: <49C6B2F6.6080304@cs.columbia.edu> References: <1237574868-3371-1-git-send-email-orenl@cs.columbia.edu> <1237574868-3371-8-git-send-email-orenl@cs.columbia.edu> <20090320235433.GA19565@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20090320235433.GA19565-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: "Serge E. Hallyn" Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Dave Hansen List-Id: containers.vger.kernel.org Serge E. Hallyn wrote: > Quoting Oren Laadan (orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org): >> + ret = -EINVAL; >> + if (hh->vdso != (unsigned long) mm->context.vdso) >> + goto out; > > We were just talking about vdso+s390 on irc this morning, > wondering about how to handle it... > > Looking at arch/x86/vdso/vma.c, this seems like it should > pretty much always error out. The vdso base is set as a > random offset above the stack base at exec(). Yes, I was wondering too ... :( The default config is CONFIG_COMPAT_VDSO which disabled the randomization, that's why it works for the default case on X86_32. I think the code is mainly in arch/x86/vdso/vdso32_setup.c. Oren.