From: Gui Jianfeng <guijianfeng-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
To: Andrea Righi <righi.andrea-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org,
Paul Menage <menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
Carl Henrik Lunde
<chlunde-om2ZC0WAoZIXWF+eFR7m5Q@public.gmane.org>,
eric.rannaud-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
Balbir Singh
<balbir-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>,
paolo.valente-rcYM44yAMweonA0d6jMUrA@public.gmane.org,
fernando-gVGce1chcLdL9jVzuh4AOg@public.gmane.org,
dradford-cT2on/YLNlBWk0Htik3J/w@public.gmane.org,
fchecconi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
agk-9JcytcrH/bA+uJoB2kUjGw@public.gmane.org,
subrata-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org,
axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
dave-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org,
matt-cT2on/YLNlBWk0Htik3J/w@public.gmane.org,
roberto-5KDOxZqKugI@public.gmane.org,
ngupta-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH 5/7] kiothrottled: throttle buffered (writeback) IO
Date: Thu, 23 Apr 2009 15:53:51 +0800 [thread overview]
Message-ID: <49F01E8F.80807@cn.fujitsu.com> (raw)
In-Reply-To: <1240090712-1058-6-git-send-email-righi.andrea-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Andrea Righi wrote:
> Together with cgroup_io_throttle() the kiothrottled kernel thread
> represents the core of the io-throttle subsystem.
>
> All the writeback IO requests that need to be throttled are not
> dispatched immediately in submit_bio(). Instead, they are added into an
> rbtree by iothrottle_make_request() and processed asynchronously by
> kiothrottled.
>
> A deadline is associated to each request depending on the bandwidth
> usage of the cgroup it belongs. When a request is inserted into the
> rbtree kiothrottled is awakened. This thread selects all the requests
> with an expired deadline and submit the bunch of selected requests to
> the underlying block devices using generic_make_request().
Hi Andrea,
What if an user issues "sync", will the bios still be buffered in the rb-tree?
Do we need to flush the whole tree?
--
Regards
Gui Jianfeng
next prev parent reply other threads:[~2009-04-23 7:53 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1240090712-1058-1-git-send-email-righi.andrea@gmail.com>
[not found] ` <1240090712-1058-1-git-send-email-righi.andrea-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2009-04-18 21:38 ` [PATCH 1/7] io-throttle documentation Andrea Righi
2009-04-18 21:38 ` [PATCH 2/7] res_counter: introduce ratelimiting attributes Andrea Righi
2009-04-18 21:38 ` [PATCH 3/7] page_cgroup: provide a generic page tracking infrastructure Andrea Righi
2009-04-18 21:38 ` [PATCH 4/7] io-throttle controller infrastructure Andrea Righi
2009-04-18 21:38 ` [PATCH 5/7] kiothrottled: throttle buffered (writeback) IO Andrea Righi
2009-04-18 21:38 ` [PATCH 6/7] io-throttle instrumentation Andrea Righi
2009-04-18 21:38 ` [PATCH 7/7] export per-task io-throttle statistics to userspace Andrea Righi
[not found] ` <1240090712-1058-5-git-send-email-righi.andrea@gmail.com>
[not found] ` <1240090712-1058-5-git-send-email-righi.andrea-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2009-04-20 17:59 ` [PATCH 4/7] io-throttle controller infrastructure Paul E. McKenney
[not found] ` <20090420175904.GD6822@linux.vnet.ibm.com>
[not found] ` <20090420175904.GD6822-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2009-04-20 21:22 ` Andrea Righi
[not found] ` <20090420212225.GA5819@linux>
2009-04-21 4:15 ` Paul E. McKenney
[not found] ` <20090421041524.GB6939@linux.vnet.ibm.com>
[not found] ` <20090421041524.GB6939-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2009-04-21 12:58 ` Andrea Righi
[not found] ` <20090421125829.GD13699@linux>
2009-04-21 14:03 ` Paul E. McKenney
[not found] ` <1240090712-1058-3-git-send-email-righi.andrea@gmail.com>
[not found] ` <1240090712-1058-3-git-send-email-righi.andrea-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2009-04-21 0:15 ` [PATCH 2/7] res_counter: introduce ratelimiting attributes KAMEZAWA Hiroyuki
2009-04-21 10:13 ` Balbir Singh
[not found] ` <20090421091534.971f676f.kamezawa.hiroyu@jp.fujitsu.com>
[not found] ` <20090421091534.971f676f.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2009-04-21 9:55 ` Andrea Righi
[not found] ` <20090421095525.GA13699@linux>
2009-04-21 10:16 ` Balbir Singh
2009-04-21 10:19 ` KAMEZAWA Hiroyuki
[not found] ` <20090421101659.GF19637@balbir.in.ibm.com>
[not found] ` <20090421101659.GF19637-SINUvgVNF2CyUtPGxGje5AC/G2K4zDHf@public.gmane.org>
2009-04-21 14:17 ` Andrea Righi
[not found] ` <20090421101326.GE19637@balbir.in.ibm.com>
[not found] ` <20090421101326.GE19637-SINUvgVNF2CyUtPGxGje5AC/G2K4zDHf@public.gmane.org>
2009-04-21 11:16 ` Andrea Righi
[not found] ` <1240090712-1058-6-git-send-email-righi.andrea@gmail.com>
[not found] ` <1240090712-1058-6-git-send-email-righi.andrea-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2009-04-23 7:53 ` Gui Jianfeng [this message]
[not found] ` <49F01E8F.80807-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2009-04-23 10:25 ` [PATCH 5/7] kiothrottled: throttle buffered (writeback) IO Andrea Righi
[not found] ` <20090423102551.GB16768@linux>
2009-04-24 6:36 ` Gui Jianfeng
[not found] ` <1240090712-1058-4-git-send-email-righi.andrea@gmail.com>
[not found] ` <1240090712-1058-4-git-send-email-righi.andrea-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2009-04-24 2:11 ` [PATCH 3/7] page_cgroup: provide a generic page tracking infrastructure Gui Jianfeng
[not found] ` <49F11FBD.3070705@cn.fujitsu.com>
[not found] ` <49F11FBD.3070705-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2009-04-24 8:31 ` Andrea Righi
[not found] ` <20090424083116.GB8535@linux>
2009-04-24 9:14 ` Gui Jianfeng
[not found] ` <49F1830F.8020609@cn.fujitsu.com>
[not found] ` <49F1830F.8020609-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2009-04-26 17:19 ` Andrea Righi
[not found] <1241350583-9871-1-git-send-email-righi.andrea@gmail.com>
[not found] ` <1241350583-9871-1-git-send-email-righi.andrea-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2009-05-03 11:36 ` [PATCH 5/7] kiothrottled: throttle buffered (writeback) IO Andrea Righi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49F01E8F.80807@cn.fujitsu.com \
--to=guijianfeng-bthxqxjhjhxqfuhtdcdx3a@public.gmane.org \
--cc=agk-9JcytcrH/bA+uJoB2kUjGw@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org \
--cc=balbir-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
--cc=chlunde-om2ZC0WAoZIXWF+eFR7m5Q@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=dave-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
--cc=dradford-cT2on/YLNlBWk0Htik3J/w@public.gmane.org \
--cc=eric.rannaud-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=fchecconi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=fernando-gVGce1chcLdL9jVzuh4AOg@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matt-cT2on/YLNlBWk0Htik3J/w@public.gmane.org \
--cc=menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=ngupta-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=paolo.valente-rcYM44yAMweonA0d6jMUrA@public.gmane.org \
--cc=randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=righi.andrea-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=roberto-5KDOxZqKugI@public.gmane.org \
--cc=subrata-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox