From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oren Laadan Subject: Re: [PATCH 4/6] cr: checkpoint and restore task credentials Date: Wed, 20 May 2009 12:56:54 -0400 Message-ID: <4A143656.9080001@cs.columbia.edu> References: <20090519014446.GA28277@us.ibm.com> <20090519014538.GD28312@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20090519014538.GD28312-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: "Serge E. Hallyn" Cc: Linux Containers , David Howells , alexey-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org List-Id: containers.vger.kernel.org Serge E. Hallyn wrote: > +static struct user_namespace *restore_read_userns(struct ckpt_ctx *ctx) > +{ > + struct ckpt_hdr_user_ns *h; > + struct user_namespace *ns; > + struct user_struct *new_root, *creator; > + > + h = ckpt_read_obj_type(ctx, sizeof(*h), CKPT_HDR_USER_NS); > + if (IS_ERR(h)) > + return ERR_PTR(PTR_ERR(h)); > + if (h->flags & CKPT_USERNS_INIT) { Perhaps make it future-safe by disallowing other flags ? > + ckpt_hdr_put(ctx, h); > + /* grab an extra ref bc objhash will drop an extra */ > + return get_user_ns(current_user_ns()); > + } Oren.