Linux Container Development
 help / color / mirror / Atom feed
From: Oren Laadan <orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
To: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: Linux Containers <containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>
Subject: Re: [PATCH 1/1] cr: nsproxy: fix refcounting
Date: Wed, 27 May 2009 14:57:46 -0400	[thread overview]
Message-ID: <4A1D8D2A.8000709@cs.columbia.edu> (raw)
In-Reply-To: <20090526220313.GA18572-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>

thanks, applied.

Serge E. Hallyn wrote:
> [This is the fix for the bug I was trying to nail down earlier today]
> 
> If more than one restarted task are to share a checkpointed nsproxy,
> then we must inc the count on the nsproxy for each new task, as
> switch_task_namespaces() does not do that for us.
> 
> Signed-off-by: Serge E. Hallyn <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> ---
>  checkpoint/process.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/checkpoint/process.c b/checkpoint/process.c
> index fa166cd..52d2a9c 100644
> --- a/checkpoint/process.c
> +++ b/checkpoint/process.c
> @@ -603,8 +603,10 @@ static int restore_ns_obj(struct ckpt_ctx *ctx, int ns_objref)
>  	if (IS_ERR(nsproxy))
>  		return PTR_ERR(nsproxy);
>  
> -	if (nsproxy != task_nsproxy(current))
> +	if (nsproxy != task_nsproxy(current)) {
> +		get_nsproxy(nsproxy);
>  		switch_task_namespaces(current, nsproxy);
> +	}
>  
>  	return 0;
>  }

      parent reply	other threads:[~2009-05-27 18:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-26 22:03 [PATCH 1/1] cr: nsproxy: fix refcounting Serge E. Hallyn
     [not found] ` <20090526220313.GA18572-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-05-27 18:57   ` Oren Laadan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A1D8D2A.8000709@cs.columbia.edu \
    --to=orenl-eqauephvms7envbuuze7ea@public.gmane.org \
    --cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
    --cc=serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox