Linux Container Development
 help / color / mirror / Atom feed
From: Gui Jianfeng <guijianfeng-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
To: Vivek Goyal <vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: dhaval-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org,
	snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	jens.axboe-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org,
	agk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	balbir-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org,
	paolo.valente-rcYM44yAMweonA0d6jMUrA@public.gmane.org,
	fernando-gVGce1chcLdL9jVzuh4AOg@public.gmane.org,
	jmoyer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	fchecconi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	righi.andrea-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Subject: Re: [PATCH 02/20] io-controller: Common flat fair queuing code in elevaotor layer
Date: Mon, 08 Jun 2009 15:44:31 +0800	[thread overview]
Message-ID: <4A2CC15F.2010708@cn.fujitsu.com> (raw)
In-Reply-To: <1243377729-2176-3-git-send-email-vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

Vivek Goyal wrote:
...
> +
> +static inline pid_t elv_ioq_pid(struct io_queue *ioq)
> +{
> +	return ioq->pid;
> +}
> +
> +static inline unsigned long elv_ioq_ttime_mean(struct io_queue *ioq)
> +{
> +	return ioq->ttime_mean;
> +}
> +
> +static inline unsigned long elv_ioq_sample_valid(struct io_queue *ioq)
> +{
> +	return ioq_sample_valid(ioq->ttime_samples);
> +}
> +

These three functions are dead now, just remove them.

Signed-off-by: Gui Jianfeng <guijianfeng-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
---
 block/elevator-fq.h |   15 ---------------
 1 files changed, 0 insertions(+), 15 deletions(-)

diff --git a/block/elevator-fq.h b/block/elevator-fq.h
index 24a3af9..b2bb11a 100644
--- a/block/elevator-fq.h
+++ b/block/elevator-fq.h
@@ -452,21 +452,6 @@ static inline int elv_ioq_nr_queued(struct io_queue *ioq)
 	return ioq->nr_queued;
 }
 
-static inline pid_t elv_ioq_pid(struct io_queue *ioq)
-{
-	return ioq->pid;
-}
-
-static inline unsigned long elv_ioq_ttime_mean(struct io_queue *ioq)
-{
-	return ioq->ttime_mean;
-}
-
-static inline unsigned long elv_ioq_sample_valid(struct io_queue *ioq)
-{
-	return ioq_sample_valid(ioq->ttime_samples);
-}
-
 static inline void elv_get_ioq(struct io_queue *ioq)
 {
 	atomic_inc(&ioq->ref);
-- 
1.5.4.rc3

  parent reply	other threads:[~2009-06-08  7:44 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1243377729-2176-1-git-send-email-vgoyal@redhat.com>
     [not found] ` <1243377729-2176-1-git-send-email-vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-05-26 22:41   ` [PATCH 01/20] io-controller: Documentation Vivek Goyal
2009-05-26 22:41   ` [PATCH 02/20] io-controller: Common flat fair queuing code in elevaotor layer Vivek Goyal
     [not found]     ` <1243377729-2176-3-git-send-email-vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-05-27 20:53       ` Nauman Rafique
2009-06-08  1:08       ` Gui Jianfeng
2009-06-08  7:44       ` Gui Jianfeng [this message]
     [not found]         ` <4A2CC15F.2010708-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2009-06-08 13:56           ` Vivek Goyal
     [not found]     ` <e98e18940905271353kc6890dbxa1ea63026c8faec1@mail.gmail.com>
     [not found]       ` <e98e18940905271353kc6890dbxa1ea63026c8faec1-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-05-28  8:52         ` Fabio Checconi
2009-05-28 16:00         ` Vivek Goyal
     [not found]       ` <20090528160003.GA4335@redhat.com>
     [not found]         ` <20090528160003.GA4335-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-05-28 19:41           ` Nauman Rafique
     [not found]         ` <e98e18940905281241v4aa24716j91f351a828af604a@mail.gmail.com>
     [not found]           ` <e98e18940905281241v4aa24716j91f351a828af604a-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-05-29 16:06             ` Vivek Goyal
     [not found]           ` <20090529160610.GC26962@redhat.com>
     [not found]             ` <20090529160610.GC26962-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-05-29 16:57               ` Fabio Checconi
     [not found]             ` <20090529165716.GB18141@gandalf.sssup.it>
     [not found]               ` <20090529165716.GB18141-f9ZlEuEWxVeACYmtYXMKmw@public.gmane.org>
2009-05-29 19:06                 ` Nauman Rafique
     [not found]               ` <e98e18940905291206p2e05bc5cxf499479270e34074@mail.gmail.com>
     [not found]                 ` <e98e18940905291206p2e05bc5cxf499479270e34074-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-05-29 19:16                   ` Vivek Goyal
     [not found]     ` <4A2C649C.8070806@cn.fujitsu.com>
     [not found]       ` <4A2C649C.8070806-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2009-06-08 12:58         ` Vivek Goyal
2009-05-26 22:41   ` [PATCH 03/20] io-controller: Charge for time slice based on average disk rate Vivek Goyal
2009-05-26 22:41   ` [PATCH 04/20] io-controller: Modify cfq to make use of flat elevator fair queuing Vivek Goyal
2009-05-26 22:41   ` [PATCH 05/20] io-controller: Common hierarchical fair queuing code in elevaotor layer Vivek Goyal
2009-05-26 22:41   ` [PATCH 06/20] io-controller: cfq changes to use " Vivek Goyal
2009-05-26 22:41   ` [PATCH 07/20] io-controller: Export disk time used and nr sectors dipatched through cgroups Vivek Goyal
2009-05-26 22:41   ` [PATCH 08/20] io-controller: idle for sometime on sync queue before expiring it Vivek Goyal
2009-05-26 22:41   ` [PATCH 09/20] io-controller: Separate out queue and data Vivek Goyal
2009-05-26 22:41   ` [PATCH 10/20] io-conroller: Prepare elevator layer for single queue schedulers Vivek Goyal
2009-05-26 22:42   ` [PATCH 11/20] io-controller: noop changes for hierarchical fair queuing Vivek Goyal
2009-05-26 22:42   ` [PATCH 12/20] io-controller: deadline " Vivek Goyal
2009-05-26 22:42   ` [PATCH 13/20] io-controller: anticipatory " Vivek Goyal
2009-05-26 22:42   ` [PATCH 14/20] blkio_cgroup patches from Ryo to track async bios Vivek Goyal
2009-05-26 22:42   ` [PATCH 15/20] io-controller: map async requests to appropriate cgroup Vivek Goyal
2009-05-26 22:42   ` [PATCH 16/20] io-controller: IO group refcounting support Vivek Goyal
2009-05-26 22:42   ` [PATCH 17/20] io-controller: Per cgroup request descriptor support Vivek Goyal
2009-05-26 22:42   ` [PATCH 18/20] io-controller: Support per cgroup per device weights and io class Vivek Goyal
2009-05-26 22:42   ` [PATCH 19/20] io-controller: Debug hierarchical IO scheduling Vivek Goyal
2009-05-26 22:42   ` [PATCH 20/20] io-controller: experimental debug patch for async queue wait before expiry Vivek Goyal
     [not found] ` <1243377729-2176-16-git-send-email-vgoyal@redhat.com>
     [not found]   ` <1243377729-2176-16-git-send-email-vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-05-28  9:27     ` [PATCH 15/20] io-controller: map async requests to appropriate cgroup Ryo Tsuruta
     [not found]   ` <20090528.182740.193697101.ryov@valinux.co.jp>
     [not found]     ` <20090528.182740.193697101.ryov-jCdQPDEk3idL9jVzuh4AOg@public.gmane.org>
2009-05-28 16:57       ` Vivek Goyal
     [not found]     ` <20090528165710.GB4335@redhat.com>
     [not found]       ` <20090528165710.GB4335-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-05-29  3:17         ` Ryo Tsuruta
     [not found]       ` <20090529.121737.189708024.ryov@valinux.co.jp>
     [not found]         ` <20090529.121737.189708024.ryov-jCdQPDEk3idL9jVzuh4AOg@public.gmane.org>
2009-05-29 13:38           ` Vivek Goyal
     [not found]         ` <20090529133804.GA26962@redhat.com>
     [not found]           ` <20090529133804.GA26962-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-06-01 11:25             ` Ryo Tsuruta
     [not found] ` <1243377729-2176-2-git-send-email-vgoyal@redhat.com>
     [not found]   ` <1243377729-2176-2-git-send-email-vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-05-29 15:42     ` [PATCH 01/20] io-controller: Documentation Balbir Singh
     [not found]   ` <20090529154252.GD5587@balbir.in.ibm.com>
     [not found]     ` <20090529154252.GD5587-SINUvgVNF2CyUtPGxGje5AC/G2K4zDHf@public.gmane.org>
2009-05-29 15:53       ` Vivek Goyal
     [not found] ` <1243377729-2176-11-git-send-email-vgoyal@redhat.com>
     [not found]   ` <1243377729-2176-11-git-send-email-vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-06-05  9:17     ` [PATCH 10/20] io-conroller: Prepare elevator layer for single queue schedulers Gui Jianfeng
     [not found]   ` <4A28E293.90402@cn.fujitsu.com>
     [not found]     ` <4A28E293.90402-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2009-06-05 13:22       ` Vivek Goyal
     [not found] ` <1243377729-2176-6-git-send-email-vgoyal@redhat.com>
     [not found]   ` <1243377729-2176-6-git-send-email-vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-06-05  9:36     ` [PATCH 05/20] io-controller: Common hierarchical fair queuing code in elevaotor layer Gui Jianfeng
     [not found]   ` <4A28E710.5080307@cn.fujitsu.com>
     [not found]     ` <4A28E710.5080307-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2009-06-05 13:21       ` Vivek Goyal
     [not found] ` <1243377729-2176-17-git-send-email-vgoyal@redhat.com>
     [not found]   ` <1243377729-2176-17-git-send-email-vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-06-08  2:03     ` [PATCH 16/20] io-controller: IO group refcounting support Gui Jianfeng
     [not found]       ` <4A2C716C.8070808-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2009-06-08 13:53         ` Vivek Goyal
     [not found] <1245443858-8487-1-git-send-email-vgoyal@redhat.com>
     [not found] ` <1245443858-8487-1-git-send-email-vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-06-19 20:37   ` [PATCH 02/20] io-controller: Common flat fair queuing code in elevaotor layer Vivek Goyal
     [not found] ` <1245443858-8487-3-git-send-email-vgoyal@redhat.com>
     [not found]   ` <20090622084612.GD3728@balbir.in.ibm.com>
     [not found]     ` <20090622084612.GD3728-SINUvgVNF2CyUtPGxGje5AC/G2K4zDHf@public.gmane.org>
2009-06-22 12:43       ` Fabio Checconi
2009-06-23  2:05       ` Vivek Goyal
     [not found]     ` <20090623020515.GA3620@redhat.com>
     [not found]       ` <20090623020515.GA3620-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-06-23  2:20         ` Jeff Moyer
     [not found]     ` <20090622124313.GF28770@gandalf.sssup.it>
     [not found]       ` <20090622124313.GF28770-f9ZlEuEWxVeACYmtYXMKmw@public.gmane.org>
2009-06-23  2:43         ` Vivek Goyal
     [not found]       ` <20090623024337.GC3620@redhat.com>
     [not found]         ` <20090623024337.GC3620-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-06-23  4:10           ` Fabio Checconi
     [not found]             ` <20090623041052.GS28770-f9ZlEuEWxVeACYmtYXMKmw@public.gmane.org>
2009-06-23  7:32               ` Balbir Singh
     [not found]             ` <20090623073252.GJ8642@balbir.in.ibm.com>
     [not found]               ` <20090623073252.GJ8642-SINUvgVNF2CyUtPGxGje5AC/G2K4zDHf@public.gmane.org>
2009-06-23 13:42                 ` Fabio Checconi
     [not found]   ` <1245443858-8487-3-git-send-email-vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-06-22  8:46     ` Balbir Singh
2009-06-30  6:40     ` Gui Jianfeng
2009-07-01  9:24     ` Gui Jianfeng
     [not found]   ` <4A49B364.5000508@cn.fujitsu.com>
     [not found]     ` <4A49B364.5000508-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2009-07-01  1:28       ` Vivek Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A2CC15F.2010708@cn.fujitsu.com \
    --to=guijianfeng-bthxqxjhjhxqfuhtdcdx3a@public.gmane.org \
    --cc=agk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=balbir-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=dhaval-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
    --cc=dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=fchecconi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=fernando-gVGce1chcLdL9jVzuh4AOg@public.gmane.org \
    --cc=jens.axboe-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
    --cc=jmoyer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=paolo.valente-rcYM44yAMweonA0d6jMUrA@public.gmane.org \
    --cc=righi.andrea-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox