From: Oren Laadan <orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
To: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: Linux Containers <containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>
Subject: Re: [PATCH 1/1] restore_ipc_ns: set ret=0 if no error
Date: Mon, 15 Jun 2009 19:02:31 -0400 [thread overview]
Message-ID: <4A36D307.4040808@cs.columbia.edu> (raw)
In-Reply-To: <20090615205911.GA18820-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Heh .. I already hit this one and fixed - I am finishing a few more
fixes before pushing them all.
Thanks :)
Serge E. Hallyn wrote:
> Why pretend there's an error when there isn't?
>
> (Without this, all restarts fail with CONFIG_UTS_NS or CONFIG_IPC_NS
> on)
>
> Signed-off-by: Serge E. Hallyn <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> ---
> kernel/nsproxy.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/kernel/nsproxy.c b/kernel/nsproxy.c
> index e3db0b9..5fae13c 100644
> --- a/kernel/nsproxy.c
> +++ b/kernel/nsproxy.c
> @@ -308,6 +308,7 @@ static struct nsproxy *do_restore_ns(struct ckpt_ctx *ctx)
> nsproxy = create_nsproxy();
> if (!nsproxy)
> goto out;
> + ret = 0;
>
> get_uts_ns(uts_ns);
> nsproxy->uts_ns = uts_ns;
prev parent reply other threads:[~2009-06-15 23:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-15 20:59 [PATCH 1/1] restore_ipc_ns: set ret=0 if no error Serge E. Hallyn
[not found] ` <20090615205911.GA18820-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-06-15 23:02 ` Oren Laadan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A36D307.4040808@cs.columbia.edu \
--to=orenl-eqauephvms7envbuuze7ea@public.gmane.org \
--cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
--cc=serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox