From: Oren Laadan <orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
To: Sukadev Bhattiprolu
<sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Cc: Containers
<containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
Subject: Re: [C/R][PATCH] Have ckpt_debug() print global pid and __LINE__
Date: Thu, 02 Jul 2009 02:49:58 -0400 [thread overview]
Message-ID: <4A4C5896.8060604@cs.columbia.edu> (raw)
In-Reply-To: <20090702022541.GA31350-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Good idea - in queue for v17.
Thanks,
Oren.
Sukadev Bhattiprolu wrote:
> Have ckpt_debug() print global-pid and __LINE__
>
> Printing both global and virtual pid helps correlating dmesg with
> logs from mktree.
>
> Signed-off-by: Sukadev Bhattiprolu <sukadev-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
>
> ---
> include/linux/checkpoint.h | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> Index: linux-cr/include/linux/checkpoint.h
> ===================================================================
> --- linux-cr.orig/include/linux/checkpoint.h 2009-07-01 19:09:36.000000000 -0700
> +++ linux-cr/include/linux/checkpoint.h 2009-07-01 19:20:29.000000000 -0700
> @@ -281,12 +281,12 @@ extern int restore_signal(struct ckpt_ct
> extern unsigned long ckpt_debug_level;
>
> /* use this to select a specific debug level */
> -#define _ckpt_debug(level, fmt, args...) \
> - do { \
> - if (ckpt_debug_level & (level)) \
> - printk(KERN_DEBUG "[%d:c/r:%s] " fmt, \
> - task_pid_vnr(current), \
> - __func__, ## args); \
> +#define _ckpt_debug(level, fmt, args...) \
> + do { \
> + if (ckpt_debug_level & (level)) \
> + printk(KERN_DEBUG "[%d:%d:c/r:%s:%d] " fmt, \
> + current->pid, task_pid_vnr(current), \
> + __func__, __LINE__, ## args); \
> } while (0)
>
> /*
>
prev parent reply other threads:[~2009-07-02 6:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-02 2:25 [C/R][PATCH] Have ckpt_debug() print global pid and __LINE__ Sukadev Bhattiprolu
[not found] ` <20090702022541.GA31350-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-07-02 6:49 ` Oren Laadan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A4C5896.8060604@cs.columbia.edu \
--to=orenl-eqauephvms7envbuuze7ea@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox