From: Oren Laadan <orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
To: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: Linux Containers <containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>
Subject: Re: [PATCH 1/1] mktree: s390: don't hard-code clone-with-pids syscall
Date: Mon, 06 Jul 2009 18:56:35 -0400 [thread overview]
Message-ID: <4A528123.8090102@cs.columbia.edu> (raw)
In-Reply-To: <20090706222703.GA730-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
applied to ckpt-v17-rc1.
Oren.
Serge E. Hallyn wrote:
> Use __NR_clone_with_pids (from asm/unistd.h) as an immediate
> value instead.
>
> Signed-off-by: Serge Hallyn <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> ---
> mktree.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/mktree.c b/mktree.c
> index 76a71ac..0782068 100644
> --- a/mktree.c
> +++ b/mktree.c
> @@ -1829,11 +1829,12 @@ static int clone_with_pids(int (*fn)(void *), void *child_stack, int flags,
> register unsigned long int __r7 asm ("7") = (unsigned long int)(setp); \
> register unsigned long int __result asm ("2"); \
> __asm__ __volatile__( \
> - " lghi %%r1,332\n" \
> + " lghi %%r1,%7\n" \
> " svc 0\n" \
> : "=d" (__result) \
> : "0" (__r2), "d" (__r3), \
> - "d" (__r4), "d" (__r5), "d" (__r6), "d" (__r7) \
> + "d" (__r4), "d" (__r5), "d" (__r6), "d" (__r7), \
> + "i" (__NR_clone_with_pids) \
> : "1", "cc", "memory" \
> ); \
> __result; \
prev parent reply other threads:[~2009-07-06 22:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-06 22:27 [PATCH 1/1] mktree: s390: don't hard-code clone-with-pids syscall Serge E. Hallyn
[not found] ` <20090706222703.GA730-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-07-06 22:56 ` Oren Laadan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A528123.8090102@cs.columbia.edu \
--to=orenl-eqauephvms7envbuuze7ea@public.gmane.org \
--cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
--cc=serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox