From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oren Laadan Subject: Re: [PATCH] c/r: Add AF_UNIX support (v3) Date: Tue, 07 Jul 2009 11:48:20 -0400 Message-ID: <4A536E44.6050601@cs.columbia.edu> References: <1245167716-28906-1-git-send-email-danms@us.ibm.com> <4A42E163.1080700@cs.columbia.edu> <871vp3x81s.fsf@caffeine.danplanet.com> <4A4C7AC7.3090004@cs.columbia.edu> <87y6r1slxz.fsf@caffeine.danplanet.com> <4A524B40.4040600@cs.columbia.edu> <87tz1psbpq.fsf@caffeine.danplanet.com> <4A527EB8.4060201@cs.columbia.edu> <87prccsfyp.fsf@caffeine.danplanet.com> <4A536ABF.8060708@cs.columbia.edu> <87ab3gsdwx.fsf@caffeine.danplanet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <87ab3gsdwx.fsf-FLMGYpZoEPULwtHQx/6qkW3U47Q5hpJU@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Dan Smith Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org, Alexey Dobriyan List-Id: containers.vger.kernel.org Dan Smith wrote: > OL> Ahh.. and forgot to ask/mention: you do need to call > OL> sock_unix_unlink() before attempting bind(), for the reasons we > OL> had discussed earlier (consider same example as above, > OL> checkpoint/restart done before the unlink(), then restart will > OL> otherwise fail). > > I thought we agreed that was userspace's job? That's why I didn't > unlink() before bind() in this version (4) of the patch either. > I don't recall such a conclusion. I argued that it it's kernel's job. I suppose we agree that such pathnames should always be unlinked - so it isn't policy based. Therefore, I don't see a good reason to have userspace scan the checkpoint image data just to find such sockets and make them disappear ... Oren.