From mboxrd@z Thu Jan 1 00:00:00 1970 From: Li Zefan Subject: Re: [PATCH 1/8] Revert commit 8827c288feb7810185aa7c2e37537202fc709869 Date: Thu, 20 Aug 2009 10:34:23 +0800 Message-ID: <4A8CB62F.8030504@cn.fujitsu.com> References: <20090818235059.22531.42618.stgit@menage.mtv.corp.google.com> <20090818235812.22531.76212.stgit@menage.mtv.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20090818235812.22531.76212.stgit-u3IScbYxn0zHt/MElyovVYaSKrA+ACpX0E9HWUfgJXw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Paul Menage Cc: bblum-OM76b2Iv3yLQjUSlxSEPGw@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: containers.vger.kernel.org Paul Menage wrote: > Revert commit 8827c288feb7810185aa7c2e37537202fc709869 > > This is in preparation for some clashing cgroups changes that subsume > the original commit's functionaliy. > > Signed-off-by: Paul Menage > > -- > > The original commit fixed a pid namespace bug which Ben Blum fixed > independently (in the same way, but with different code) as part of a > series of patches. I played around with trying to reconcile Ben's > patch series with Li's patch, but concluded that it was simpler to > just revert Li's, given that Ben's patch series contained essentially > the same fix. > It's sure that reverting this commit makes things easier, but rebasing this patchset shouldn't be hard. And this doesn't sound a good reason to revert an innocent commit.