Linux Container Development
 help / color / mirror / Atom feed
From: Oren Laadan <orenl-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
To: Sukadev Bhattiprolu
	<sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Cc: Containers
	<containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
Subject: Re: Review: Can we move init_restart_ctx() up ?
Date: Fri, 02 Oct 2009 14:26:26 -0400	[thread overview]
Message-ID: <4AC645D2.7030409@librato.com> (raw)
In-Reply-To: <20091002051456.GA6684-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>



Sukadev Bhattiprolu wrote:
> 
> Would it be easier/cleaner if we initialized the restart ctx soon after
> allocating it ? Looks like we already have the information we need at that
> point.
> 
> That way, do_restart() won't need the 'pid' parameter and we anyway use
> the 'if(ctx)' check to test for the coordinator.

I put the {checkpoint,restart}-related work in {checkpoint,restart}.c,
and leave sys.c "neutral".

I also like the symmetry between do_checkpoint() and do_restart() :p

> BTW, can we move the '->active_pid = -1' in init_restart_ctx() to
> ckpt_ctx_alloc() itself ?

@active_pid is specific to restart, that's why I initialize it there.

Oren.

  parent reply	other threads:[~2009-10-02 18:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-02  5:14 Review: Can we move init_restart_ctx() up ? Sukadev Bhattiprolu
     [not found] ` <20091002051456.GA6684-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-10-02 18:26   ` Oren Laadan [this message]
     [not found]     ` <4AC645D2.7030409-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
2009-10-03  1:48       ` Sukadev Bhattiprolu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AC645D2.7030409@librato.com \
    --to=orenl-rdfvbdnroixbdgjk7y7tuq@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox