From: Oren Laadan <orenl-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
To: Matt Helsley <matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
Dan Smith <danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] Fix compile issue with CONFIG_CHECKPOINT=n for inet sockets
Date: Fri, 02 Oct 2009 14:31:07 -0400 [thread overview]
Message-ID: <4AC646EB.3050802@librato.com> (raw)
In-Reply-To: <1254476123-4939-1-git-send-email-matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Queued to ckpt-v18-dev.
Matt Helsley wrote:
> When I disable CHECKPOINT I get:
>
> net/ipv4/af_inet.c:860: error: ‘inet_checkpoint’ undeclared here (not in a function)
> net/ipv4/af_inet.c:861: error: ‘inet_restore’ undeclared here (not in a function)
> net/ipv4/af_inet.c:862: error: ‘inet_collect’ undeclared here (not in a function)
>
> Similar to problem with unix sockets. The solution is the same as well.
>
> Signed-off-by: Matt Helsley <matthltc@us.ibm.com>
> Cc: Dan Smith <danms@us.ibm.com>
> ---
> include/net/inet_common.h | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/include/net/inet_common.h b/include/net/inet_common.h
> index 7ade732..bf04e6e 100644
> --- a/include/net/inet_common.h
> +++ b/include/net/inet_common.h
> @@ -52,6 +52,10 @@ extern int inet_checkpoint(struct ckpt_ctx *ctx, struct socket *sock);
> extern int inet_collect(struct ckpt_ctx *ctx, struct socket *sock);
> extern int inet_restore(struct ckpt_ctx *cftx, struct socket *sock,
> struct ckpt_hdr_socket *h);
> +#else
> +#define inet_checkpoint NULL
> +#define inet_collect NULL
> +#define inet_restore NULL
> #endif /* CONFIG_CHECKPOINT */
>
> static inline void inet_ctl_sock_destroy(struct sock *sk)
_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
prev parent reply other threads:[~2009-10-02 18:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-02 9:35 [PATCH] Fix compile issue with CONFIG_CHECKPOINT=n for inet sockets Matt Helsley
[not found] ` <1254476123-4939-1-git-send-email-matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-10-02 13:34 ` Dan Smith
[not found] ` <87iqexhqc4.fsf-FLMGYpZoEPULwtHQx/6qkW3U47Q5hpJU@public.gmane.org>
2009-10-02 19:47 ` Matt Helsley
2009-10-02 18:31 ` Oren Laadan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AC646EB.3050802@librato.com \
--to=orenl-rdfvbdnroixbdgjk7y7tuq@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
--cc=matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox