From: Oren Laadan <orenl-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
To: Matt Helsley <matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Subject: Re: [PATCH 2/4] Cleanup pre_restore_task comments
Date: Wed, 14 Oct 2009 18:34:05 -0400 [thread overview]
Message-ID: <4AD651DD.8020004@librato.com> (raw)
In-Reply-To: <1255481585-32625-2-git-send-email-matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Ok, pulled.
Matt Helsley wrote:
> We don't need to include the name of the function in the comment unless
> it's a kerneldoc comment -- it's redundant. Also the comment before
> post_restore_task() was copy-pasted without modification.
>
> Signed-off-by: Matt Helsley <matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> ---
> checkpoint/process.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/checkpoint/process.c b/checkpoint/process.c
> index c51e036..17c08e8 100644
> --- a/checkpoint/process.c
> +++ b/checkpoint/process.c
> @@ -814,7 +814,7 @@ static int restore_task_pgid(struct ckpt_ctx *ctx)
> return ret;
> }
>
> -/* pre_restore_task - prepare the task for restore */
> +/* prepare the task for restore */
> int pre_restore_task(struct ckpt_ctx *ctx)
> {
> sigset_t sigset;
> @@ -844,7 +844,6 @@ int pre_restore_task(struct ckpt_ctx *ctx)
> return 0;
> }
>
> -/* pre_restore_task - prepare the task for restore */
> void post_restore_task(struct ckpt_ctx *ctx)
> {
> /* can happen if restart failed early */
prev parent reply other threads:[~2009-10-14 22:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-14 0:53 [PATCH 2/4] Cleanup pre_restore_task comments Matt Helsley
[not found] ` <1255481585-32625-2-git-send-email-matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-10-14 22:34 ` Oren Laadan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AD651DD.8020004@librato.com \
--to=orenl-rdfvbdnroixbdgjk7y7tuq@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox