Linux Container Development
 help / color / mirror / Atom feed
From: Daniel Lezcano <dlezcano-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
To: Cedric Le Goater <legoater-GANU6spQydw@public.gmane.org>
Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	Daniel Lezcano <dlezcano-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>,
	Paul Menage <menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Subject: Re: [patch 4/5] cgroup: pass the clone_flags to the	cgroup_fork_callback
Date: Fri, 06 Nov 2009 11:50:56 +0100	[thread overview]
Message-ID: <4AF3FF90.7040100@fr.ibm.com> (raw)
In-Reply-To: <4AF3DC81.1010603-GANU6spQydw@public.gmane.org>

Cedric Le Goater wrote:
> On 11/05/2009 09:21 PM, Daniel Lezcano wrote:
>   
>> The fork callback is called but with just the task as parameter.
>> This one is fine to retrieve the different parameters passed to
>> the copy_process function but the clone_flags information is
>> missing, so the hook in the cgroup won't be able to use of it.
>>
>> This patch passes the clone_flags to the cgroup fork callback.
>> That will be useful for a cgroup making process and thread
>> accounting for example.
>>
>> Signed-off-by: Daniel Lezcano <dlezcano-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
>> Signed-off-by: Cedric Le Goater <clg-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
>> ---
>>  include/linux/cgroup.h  |    9 ++++++---
>>  kernel/cgroup.c         |    4 ++--
>>  kernel/cgroup_freezer.c |    3 ++-
>>  kernel/fork.c           |    2 +-
>>  4 files changed, 11 insertions(+), 7 deletions(-)
>>     
>
> it lacks a small change in :
>
> 	Documentation/cgroups/cgroups.txt
>
> same comment for the following patch :
>
> 	[patch 5/5] cgroup: call cgroup_exit with do_exit parameter
>   
Right, thanks Cedric.

      parent reply	other threads:[~2009-11-06 10:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20091105202143.180978630@mai-009101017029.toulouse-stg.fr.ibm.com>
     [not found] ` <20091105202810.809650098@mai-009101017029.toulouse-stg.fr.ibm.com>
     [not found]   ` <20091105202810.809650098-+lpkiSBCrgqwGcPS5fe+fxcU4LlsiAD9x8DZ0lRKBDr1ENwx4SLHqw@public.gmane.org>
2009-11-06  8:21     ` [patch 4/5] cgroup: pass the clone_flags to the cgroup_fork_callback Cedric Le Goater
     [not found]       ` <4AF3DC81.1010603-GANU6spQydw@public.gmane.org>
2009-11-06 10:50         ` Daniel Lezcano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AF3FF90.7040100@fr.ibm.com \
    --to=dlezcano-nmtc/0zbporqt0dzr+alfa@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=legoater-GANU6spQydw@public.gmane.org \
    --cc=menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox