From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oren Laadan Subject: Re: [PATCH 1/6] add image offset to ckpt_err output Date: Wed, 25 Nov 2009 13:49:16 -0500 Message-ID: <4B0D7C2C.70605@cs.columbia.edu> References: <1258509213-15318-1-git-send-email-serue@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1258509213-15318-1-git-send-email-serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org List-Id: containers.vger.kernel.org Cool. Entire patchset queued for v19-rc2. Thanks, Oren. serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org wrote: > From: Serge E. Hallyn > > Changelog: > Nov 17: check for len overrun > > Signed-off-by: Serge E. Hallyn > --- > checkpoint/sys.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/checkpoint/sys.c b/checkpoint/sys.c > index c1c4e99..d64f5a7 100644 > --- a/checkpoint/sys.c > +++ b/checkpoint/sys.c > @@ -471,6 +471,8 @@ static void _ckpt_msg_appendv(struct ckpt_ctx *ctx, int err, char *fmt, > goto full; > } > > + len += snprintf(&ctx->msg[len], CKPT_MSG_LEN-len, "[offset %lld]", > + ctx->total); > len += vsnprintf(&ctx->msg[len], CKPT_MSG_LEN-len, fmt, ap); > if (len > CKPT_MSG_LEN) { > full: