From mboxrd@z Thu Jan 1 00:00:00 1970 From: Li Zefan Subject: Re: [PATCH 1/4] cgroups: revamp subsys array Date: Mon, 28 Dec 2009 14:29:53 +0800 Message-ID: <4B385061.9060600@cn.fujitsu.com> References: <20091221203253.GA5683@andrew.cmu.edu> <20091221203515.GB5683@andrew.cmu.edu> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20091221203515.GB5683-OM76b2Iv3yLQjUSlxSEPGw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Ben Blum Cc: Paul Menage , containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org List-Id: containers.vger.kernel.org > Make subsys[] able to be dynamically populated to support modular subsystems > > From: Ben Blum > > This patch reworks the way the subsys[] array is used so that subsystems can > register themselves after boot time, and enables the internals of cgroups to > be able to handle when subsystems are not present or may appear/disappear. > > Signed-off-by: Ben Blum Acked-by: Li Zefan ... A small nitpick: > +/* This define indicates the maximum number of subsystems that can be loaded > + * at once. We limit to this many since cgroupfs_root has subsys_bits to keep > + * track of all of them. */ Please always use this style: /* * xxx * xxx */