From: Oren Laadan <orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
To: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: Linux Containers <containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>
Subject: Re: [PATCH 1/1] fix ifdef to shut up gcc in mm/mmap.c
Date: Thu, 04 Feb 2010 12:38:41 -0500 [thread overview]
Message-ID: <4B6B0621.6080102@cs.columbia.edu> (raw)
In-Reply-To: <20100128205333.GA5026-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Ughhh ... done.
Serge E. Hallyn wrote:
> 1. For some reason there were two lines worth of spaces at the end
> of each line
> 2. #ifdef a && b doesn't please gcc. use #if defined() && defined()
>
> Signed-off-by: Serge E. Hallyn <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> ---
> mm/mmap.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/mm/mmap.c b/mm/mmap.c
> index 0b2319f..c2451e3 100644
> --- a/mm/mmap.c
> +++ b/mm/mmap.c
> @@ -2324,10 +2324,10 @@ int special_mapping_restore(struct ckpt_ctx *ctx,
> * Even that, is very basic - call arch_setup_additional_pages
> * requiring the same mapping (start address) as before.
> */
> -#ifdef CONFIG_X86_64 && CONFIG_COMPAT
> - if (test_thread_flag(TIF_IA32))
> - return syscall32_setup_pages(NULL, h->vm_start, 0);
> -#endif
> +#if defined(CONFIG_X86_64) && defined(CONFIG_COMPAT)
> + if (test_thread_flag(TIF_IA32))
> + return syscall32_setup_pages(NULL, h->vm_start, 0);
> +#endif
> return arch_setup_additional_pages(NULL, h->vm_start, 0);
> }
> #else /* !CONFIG_CHECKPOINT */
prev parent reply other threads:[~2010-02-04 17:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-28 20:53 [PATCH 1/1] fix ifdef to shut up gcc in mm/mmap.c Serge E. Hallyn
[not found] ` <20100128205333.GA5026-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-02-04 17:38 ` Oren Laadan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B6B0621.6080102@cs.columbia.edu \
--to=orenl-eqauephvms7envbuuze7ea@public.gmane.org \
--cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
--cc=serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox