From: Oren Laadan <orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
To: Dan Smith <danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
Dave Hansen
<dave-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Subject: Re: [RFC PATCH] c/r: fixed false complaint on "unlinked" pipes, socket, etc
Date: Wed, 10 Feb 2010 11:47:38 -0500 [thread overview]
Message-ID: <4B72E32A.20802@cs.columbia.edu> (raw)
In-Reply-To: <87tytpgitd.fsf-FLMGYpZoEPULwtHQx/6qkW3U47Q5hpJU@public.gmane.org>
Heh ... following the discussion on the IRC, I actually prefer
a solution that will push tests that are not filesystm-agnostic
to the filesystem-specific .checkpoint method. Then also put
it in the generic .checkpoint method to catch the "default" case.
I think it's cleaner and does not introduce needless noise in
the kernel.
FWIW, not only for the d_unlinked() test, but also for the locks
issue; even though locks are supposed to be VFS generic and not
depend on specific filesystem, apparently they do. (Either that
or fix find_locks_with_owner() in a generic way).
Oren.
Dan Smith wrote:
> OL> Comments ?
>
> Works for me (although the issue remains that find_locks_with_owner()
> thinks there are locks present on a socket).
>
prev parent reply other threads:[~2010-02-10 16:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-05 19:57 [RFC PATCH] c/r: fixed false complaint on "unlinked" pipes, socket, etc Oren Laadan
[not found] ` <1265399854-26534-1-git-send-email-orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2010-02-06 0:08 ` Serge E. Hallyn
2010-02-10 16:24 ` Dan Smith
[not found] ` <87tytpgitd.fsf-FLMGYpZoEPULwtHQx/6qkW3U47Q5hpJU@public.gmane.org>
2010-02-10 16:47 ` Oren Laadan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B72E32A.20802@cs.columbia.edu \
--to=orenl-eqauephvms7envbuuze7ea@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
--cc=dave-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox