From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oren Laadan Subject: Re: [PATCH] user-cr: Makefile: Use standard variables Date: Mon, 01 Mar 2010 13:25:19 -0500 Message-ID: <4B8C068F.80602@cs.columbia.edu> References: <1267210602-11444-1-git-send-email-matthltc@us.ibm.com> <92a207e405307fe1dc528f59e08782985830d5e9.1267213393.git.matthltc@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <92a207e405307fe1dc528f59e08782985830d5e9.1267213393.git.matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Matt Helsley Cc: Linux-Containers , Nathan Lynch List-Id: containers.vger.kernel.org Applied, thanks. Matt Helsley wrote: > [Based on the previous series of Makefile patches] > > These are standard variables which many cross compiler systems will setup. > I believe they are also variables Make sets up with default values. > Make also sets $(MAKE) so you don't accidentally mix make binaries in the > same build -- let's use that too. > > Signed-off-by: Matt Helsley > --- > Makefile | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Makefile b/Makefile > index a4a1a8a..60ddccd 100644 > --- a/Makefile > +++ b/Makefile > @@ -34,10 +34,10 @@ LDLIBS = -lm > .PHONY: all distclean clean headers install > > all: $(PROGS) > - @make -C test > + @$(MAKE) -C test > > $(LIB_ECLONE): > - ar ruv $(LIB_ECLONE) $^ > + $(AR) ruv $(LIB_ECLONE) $^ > > # restart needs to be thread-safe > restart: CFLAGS += -D__REENTRANT -pthread > @@ -82,4 +82,4 @@ distclean: clean > > clean: > @rm -f $(PROGS) $(LIB_ECLONE) $(OTHER) *~ *.o headers.h > - @make -C test clean > + @$(MAKE) -C test clean