Linux Container Development
 help / color / mirror / Atom feed
From: Oren Laadan <orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
To: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: Linux Containers <containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>
Subject: Re: [PATCH linux-cr] send uses_interp=1 to arch_setup_additional_pages
Date: Mon, 01 Mar 2010 14:31:03 -0500	[thread overview]
Message-ID: <4B8C15F7.8000006@cs.columbia.edu> (raw)
In-Reply-To: <20100224213322.GA3502-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>


Applied.

I added the commit comment to the code, because when (and if) we
fold this to v20, the commit message will be gone.

Oren.

Serge E. Hallyn wrote:
> Because the s390 version won't set up vdso if it is 0.  It
> is safe to assume that if we are calling special_mapping_restore()
> then there is a vdso in the checkpoint image, and if that is
> the case then the checkpointed program was dynamically linked.
> 
> Other architectures ignore uses_interp so this shouldn't
> matter to them.
> 
> Signed-off-by: Serge E. Hallyn <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> ---
>  mm/mmap.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/mm/mmap.c b/mm/mmap.c
> index 6aa606a..9cded98 100644
> --- a/mm/mmap.c
> +++ b/mm/mmap.c
> @@ -2404,7 +2404,7 @@ int special_mapping_restore(struct ckpt_ctx *ctx,
>  	if (test_thread_flag(TIF_IA32))
>  		return syscall32_setup_pages(NULL, h->vm_start, 0);
>  #endif
> -	return arch_setup_additional_pages(NULL, h->vm_start, 0);
> +	return arch_setup_additional_pages(NULL, h->vm_start, 1);
>  }
>  #else /* !CONFIG_CHECKPOINT */
>  #define special_mapping_checkpoint NULL

      parent reply	other threads:[~2010-03-01 19:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-24 21:33 [PATCH linux-cr] send uses_interp=1 to arch_setup_additional_pages Serge E. Hallyn
     [not found] ` <20100224213322.GA3502-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-03-01 19:31   ` Oren Laadan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B8C15F7.8000006@cs.columbia.edu \
    --to=orenl-eqauephvms7envbuuze7ea@public.gmane.org \
    --cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
    --cc=serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox