Re: [PATCH 1/2] Fix app_checkpoint() return code

[Oren Laadan <orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>]

Both patches applies in user-cr:ckpt-v20-dev.

Oren.

Sukadev Bhattiprolu wrote:
> From: Sukadev Bhattiprolu <sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
> Date: Tue, 30 Mar 2010 18:59:10 -0700
> Subject: [PATCH 1/2] Fix app_checkpoint() return code
> 
> Have app_checkpoint() return the return value from the system call
> so callers find some useful information. Have main() can convert the
> return value into a suitable exit status.
> 
> Signed-off-by: Sukadev Bhattiprolu <sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
> ---
>  checkpoint-main.c |    4 +++-
>  checkpoint.c      |    2 +-
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/checkpoint-main.c b/checkpoint-main.c
> index f6faa32..bac65cc 100644
> --- a/checkpoint-main.c
> +++ b/checkpoint-main.c
> @@ -145,6 +145,7 @@ static void parse_args(struct app_checkpoint_args *args, int argc, char *argv[])
>  
>  int main(int argc, char *argv[])
>  {
> +	int ret;
>  	struct app_checkpoint_args args;
>  	unsigned long flags = 0;
>  	pid_t pid;
> @@ -167,5 +168,6 @@ int main(int argc, char *argv[])
>  	if (!args.container)
>  		flags |= CHECKPOINT_SUBTREE;
>  
> -	return app_checkpoint(pid, flags, &args);
> +	ret = app_checkpoint(pid, flags, &args);
> +	return (ret > 0) ? 0 : 1;
>  }
> diff --git a/checkpoint.c b/checkpoint.c
> index e3a1ce8..e0290c9 100644
> --- a/checkpoint.c
> +++ b/checkpoint.c
> @@ -55,5 +55,5 @@ int app_checkpoint(int pid, unsigned long flags,
>  		ckpt_err("checkpoint id %d\n", ret);
>  	}
>  
> -	return (ret > 0 ? 0 : 1);
> +	return ret;
>  }