Linux Container Development
 help / color / mirror / Atom feed
From: Oren Laadan <orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
To: John Paul Walters <jpnwalters-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Dan Smith <danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>,
	containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Subject: Re: multi-threaded app fails to restart
Date: Mon, 26 Jul 2010 14:18:54 -0400	[thread overview]
Message-ID: <4C4DD18E.4070905@cs.columbia.edu> (raw)
In-Reply-To: <AANLkTikaaxCdjgKywJ6SvHpez_R1PNiW5LzNYAdAONxr-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>


Great.
Pushed fixes to ckpt-v22-dev.

Oren.

On 07/26/2010 01:56 PM, John Paul Walters wrote:
> It works for me as well.  Thanks for your help Oren.
> 
> JP
> 
> 
> 
> On Mon, Jul 26, 2010 at 1:11 PM, Dan Smith <danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> wrote:
>> OL> diff --git a/kernel/checkpoint/sys.c b/kernel/checkpoint/sys.c
>> OL> index 171c867..c5517c2 100644
>> OL> --- a/kernel/checkpoint/sys.c
>> OL> +++ b/kernel/checkpoint/sys.c
>> OL> @@ -625,8 +625,11 @@ int walk_task_subtree(struct task_struct *root,
>> OL>             }
>>
>> OL>             /* if we arrive at root again -- done */
>> OL> -           if (task == root)
>> OL> -                   break;
>> OL> +           if (task == root) {
>> OL> +                   /* if not last thread - proceed with thread */
>> OL> +                   task = root = next_thread(task);
>> OL> +                   if (thread_group_leader(task))
>> OL> +                           break;
>>
>>                } // Need to close this block
>>
>> Otherwise it seems to work for me:
>>
>> Tested-by: Dan Smith <danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
>>
>> --
>> Dan Smith
>> IBM Linux Technology Center
>> email: danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org
>>
> 

      parent reply	other threads:[~2010-07-26 18:18 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-19 19:36 multi-threaded app fails to restart John Paul Walters
     [not found] ` <AANLkTilxfsYGyYLwO__VmDLSFQ_s_Qe03G49kIEztVja-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-07-19 19:54   ` Nathan Lynch
2010-07-19 20:27     ` John Paul Walters
     [not found]       ` <AANLkTimpXSXQr1wew1wvZKnBFsOXD7f2tblY4EGmJoFM-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-07-20  3:24         ` Oren Laadan
     [not found]           ` <4C4516DD.1000809-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2010-07-20 18:58             ` John Paul Walters
     [not found]               ` <AANLkTimPENgm-LSh6iMv2uxegRdHEivbGMTYmEfiOEJG-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-07-20 23:12                 ` Oren Laadan
     [not found]                   ` <Pine.LNX.4.64.1007201906370.15255-CXF6herHY6ykSYb+qCZC/1i27PF6R63G9nwVQlTi/Pw@public.gmane.org>
2010-07-21  0:03                     ` John Paul Walters
     [not found]                       ` <AANLkTinZYiWPtSegjRJWnlc6hipFAZyujr8-2ug6ettF-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-07-21  5:54                         ` Oren Laadan
     [not found]                           ` <Pine.LNX.4.64.1007210143120.22870-CXF6herHY6ykSYb+qCZC/1i27PF6R63G9nwVQlTi/Pw@public.gmane.org>
2010-07-21 12:52                             ` John Paul Walters
     [not found]                               ` <AANLkTinOFIzK8RZnp9NHouKv-WA7Omr08pPTGfrfVLfP-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-07-22  1:04                                 ` Oren Laadan
     [not found]                                   ` <Pine.LNX.4.64.1007212102010.6257-CXF6herHY6ykSYb+qCZC/1i27PF6R63G9nwVQlTi/Pw@public.gmane.org>
2010-07-22 16:23                                     ` John Paul Walters
     [not found]                                       ` <AANLkTimW98q0sFZeCAk3xHsEfBV9yhL4kUKHjNGxn_2P-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-07-26 11:18                                         ` Oren Laadan
     [not found]                                           ` <Pine.LNX.4.64.1007260711310.1050-CXF6herHY6ykSYb+qCZC/1i27PF6R63G9nwVQlTi/Pw@public.gmane.org>
2010-07-26 17:11                                             ` Dan Smith
     [not found]                                               ` <8739v6tbgj.fsf-FLMGYpZoEPULwtHQx/6qkW3U47Q5hpJU@public.gmane.org>
2010-07-26 17:56                                                 ` John Paul Walters
     [not found]                                                   ` <AANLkTikaaxCdjgKywJ6SvHpez_R1PNiW5LzNYAdAONxr-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-07-26 18:18                                                     ` Oren Laadan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C4DD18E.4070905@cs.columbia.edu \
    --to=orenl-eqauephvms7envbuuze7ea@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
    --cc=jpnwalters-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox