From mboxrd@z Thu Jan 1 00:00:00 1970 From: Li Zefan Subject: Re: [PATCH 2/3] cgroup : make the mount options parsing more accurate Date: Tue, 03 Aug 2010 16:30:58 +0800 Message-ID: <4C57D3C2.6040805@cn.fujitsu.com> References: <20100729195629.GA13378@hallyn.com> <20100729195736.GA19015@hallyn.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20100729195736.GA19015-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: "Serge E. Hallyn" Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Eric W. Biederman" , Paul Menage , Andrew Morton List-Id: containers.vger.kernel.org Cc: Andrew Serge E. Hallyn wrote: > The actual code does not detect 'all' with one subsystem name, which > is IMHO mutually exclusive and when an option is specified even if it > is not a subsystem name, we have to specify the 'all' option with the > other option. > eg: > not detected : mount -t cgroup -o all,freezer cgroup /cgroup > not flexible : mount -t cgroup -o noprefix,all cgroup /cgroup > > This patch fix this and makes the code a bit more clear by replacing > 'else if' indentation by 'continue' blocks in the loop. > > Signed-off-by: Daniel Lezcano > Signed-off-by: Serge E. Hallyn > Cc: Eric W. Biederman > Cc: Paul Menage Reviewed-by: Li Zefan