Re: [PATCH 1/3] cgroup : add clone_children control file

[Daniel Lezcano <daniel.lezcano-GANU6spQydw@public.gmane.org>]

On 09/07/2010 09:34 PM, Paul Menage wrote:
> On Sat, Sep 4, 2010 at 12:31 AM, Daniel Lezcano<daniel.lezcano-GANU6spQydw@public.gmane.org>  wrote:
>    
>> @@ -229,6 +229,7 @@ inline int cgroup_is_removed(const struct cgroup *cgrp)
>>   /* bits in struct cgroupfs_root flags field */
>>   enum {
>>         ROOT_NOPREFIX, /* mounted subsystems have no named prefix */
>> +       ROOT_CLONE_CHILDREN, /* mounted subsystems will inherit from parent */
>>   };
>>      
> This bit is awkward - you're storing the original value of the
> clone_children flag to report in the mount options, but this isn't
> necessarily the current state. Might it be better to not store this
> and just report the current value of the root cgroup's
> CGRP_CLONE_CHILDREN flag?
>    

Sure. Shall I do the same as the release agent mount option ?

Thanks
   -- Daniel