Linux Container Development
 help / color / mirror / Atom feed
From: Oren Laadan <orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
To: Matt Helsley <matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: Linux Containers
	<containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>,
	Nathan Lynch <ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] powerpc: Remove remaining debugreg bits from forward port of v22-dev patches
Date: Fri, 25 Mar 2011 22:09:54 -0400	[thread overview]
Message-ID: <4D8D4AF2.6040909@cs.columbia.edu> (raw)
In-Reply-To: <cd26e0322da9081a888336f40ea2057dad70cea2.1296134526.git.matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>

Matt/Nathan:

I lost track with the ppc patches - and I wouldn't be able to test
the code anyway. Any chance you could resend an updated ppc-c/r set ?

Thanks ...

Oren.


On 01/27/2011 08:22 AM, Matt Helsley wrote:
> The commit 'powerpc: provide APIs for validating and updating DABR'
> from ckpt-v22-dev can be dropped for v23-rc1 but other patches in
> the v22-dev series for powerpc use the debugreg functions introduced
> there. They can be rebased and merged with this patch and the
> debugreg code can be pushed as a later, independent patch.
> 
> Signed-off-by: Matt Helsley <matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> Cc: Nathan Lynch <ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
> ---
>  arch/powerpc/kernel/checkpoint.c |    8 --------
>  1 files changed, 0 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/powerpc/kernel/checkpoint.c b/arch/powerpc/kernel/checkpoint.c
> index 9aeab89..00fc2bb 100644
> --- a/arch/powerpc/kernel/checkpoint.c
> +++ b/arch/powerpc/kernel/checkpoint.c
> @@ -350,14 +350,6 @@ static int restore_dabr(const struct ckpt_hdr_cpu *cpu_hdr,
>  		goto out;
>  
>  	rc = -EINVAL;
> -	if (!debugreg_valid(cpu_hdr->dabr, 0))
> -		goto out;
> -
> -	rc = 0;
> -	if (!update)
> -		goto out;
> -
> -	debugreg_update(task, cpu_hdr->dabr, 0);
>  out:
>  	return rc;
>  }

      parent reply	other threads:[~2011-03-26  2:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-27 13:22 [PATCH] powerpc: Remove remaining debugreg bits from forward port of v22-dev patches Matt Helsley
     [not found] ` <cd26e0322da9081a888336f40ea2057dad70cea2.1296134526.git.matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2011-03-26  2:09   ` Oren Laadan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D8D4AF2.6040909@cs.columbia.edu \
    --to=orenl-eqauephvms7envbuuze7ea@public.gmane.org \
    --cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
    --cc=matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
    --cc=ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox