From mboxrd@z Thu Jan 1 00:00:00 1970 From: Glauber Costa Subject: Re: [PATCH] new cgroup controller "fork" Date: Thu, 3 Nov 2011 17:25:07 -0200 Message-ID: <4EB2EA93.2050206@parallels.com> References: <20111103162238.27609.11515.stgit@rabbit.intern.cm-ag> <4EB2C4A5.6000406@parallels.com> <20111103165903.GA4755@Debian-60-squeeze-64-minimal> <20111103182101.5037c1e5@lxorguk.ukuu.org.uk> <20111103185108.GA5153@Debian-60-squeeze-64-minimal> <20111103190330.02590426@lxorguk.ukuu.org.uk> <20111103192039.GA5300@Debian-60-squeeze-64-minimal> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20111103192039.GA5300@Debian-60-squeeze-64-minimal> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Alan Cox , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Frederic Weisbecker List-Id: containers.vger.kernel.org On 11/03/2011 05:20 PM, Max Kellermann wrote: > On 2011/11/03 20:03, Alan Cox wrote: >> Sure - I'm just not seeing that a whole separate cgroup for it is >> appropriate or a good plan. Anyone doing real resource management needs >> the rest of the stuff anyway. > > Right. When I saw Frederic's controller today, my first thought was > that one could move the fork limit code over into that controller. If > we reach a consensus that this would be a good idea, and would have > chances to get merged, I could probably take some time to refactor my > code. > > Max I'd advise you to take a step back and think if this is really needed. As Alan pointed out, the really expensive resource here is already being constrained by Frederic's controller. But ultimately, you're the only one that knows about your real requirements.