From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Slaby Subject: Re: [PATCH 1/1] __send_signal: pass q->info, not info, to userns_fixup_signal_uid (v2) Date: Sat, 19 Nov 2011 17:06:49 +0100 Message-ID: <4EC7D419.1090404@gmail.com> References: <20111119004148.GA16259@sergelap> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20111119004148.GA16259@sergelap> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Serge Hallyn Cc: richard-/L3Ra7n9ekc@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, oleg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, eparis-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, "Eric W. Biederman" , Andrew Morton List-Id: containers.vger.kernel.org On 11/19/2011 01:41 AM, Serge Hallyn wrote: > Eric Biederman pointed out that passing info is a bug and could lead > to a NULL pointer deref to boot. It would be great if you could describe what bug you are fixing in fact in the commit log. "Something that could lead to a bug" is not helpful at all. A link to the thread where Eric pointed *that* out would be enough. > A collection of signal, securebits, filecaps, cap_bounds, and a few other ltp > tests passed with this kernel. > > Changelog: > Nov 18: previous patch missed a leading '&' > > Signed-off-by: Serge Hallyn > --- > kernel/signal.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/kernel/signal.c b/kernel/signal.c > index c0f0782..170586b 100644 > --- a/kernel/signal.c > +++ b/kernel/signal.c > @@ -1118,7 +1118,7 @@ static int __send_signal(int sig, struct siginfo *info, struct task_struct *t, > break; > } > > - userns_fixup_signal_uid(info, t); > + userns_fixup_signal_uid(&q->info, t); > > } else if (!is_si_special(info)) { > if (sig >= SIGRTMIN && info->si_code != SI_USER) { thanks, -- js