From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Subject: Re: [PATCH] cgroup: remove redundant check Date: Thu, 20 Dec 2012 14:24:34 -0500 Message-ID: <50D365F2.7070607@oracle.com> References: <1356030701-16284-1-git-send-email-sasha.levin@oracle.com> <1356030701-16284-23-git-send-email-sasha.levin@oracle.com> <20121220191803.GA14527@htj.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20121220191803.GA14527-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Tejun Heo Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: containers.vger.kernel.org On 12/20/2012 02:18 PM, Tejun Heo wrote: > On Thu, Dec 20, 2012 at 02:11:31PM -0500, Sasha Levin wrote: >> We already know that 'event' is non-NULL, remove the redundant check. >> >> Signed-off-by: Sasha Levin > > I don't know. I kinda like that test there. It's not an error path > and tearing down everything which could have been allocated. If the > test not being used is bothering, convert return -ENOMEM to goto fail? Can't say it's bothering. If you'd prefer to leave it as is I'm okay with doing that. Thanks, Sasha