From: Kamezawa Hiroyuki <kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
To: Glauber Costa <glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
Cc: Theodore Ts'o <tytso-3s7WtUTddSA@public.gmane.org>,
hughd-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
Dave Shrinnker <david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org>,
Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
Al Viro <viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org>,
Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
Subject: Re: [PATCH v2 01/28] super: fix calculation of shrinkable objects for small numbers
Date: Mon, 01 Apr 2013 16:16:59 +0900 [thread overview]
Message-ID: <5159346B.1000000@jp.fujitsu.com> (raw)
In-Reply-To: <1364548450-28254-2-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
(2013/03/29 18:13), Glauber Costa wrote:
> The sysctl knob sysctl_vfs_cache_pressure is used to determine which
> percentage of the shrinkable objects in our cache we should actively try
> to shrink.
>
> It works great in situations in which we have many objects (at least
> more than 100), because the aproximation errors will be negligible. But
> if this is not the case, specially when total_objects < 100, we may end
> up concluding that we have no objects at all (total / 100 = 0, if total
> < 100).
>
> This is certainly not the biggest killer in the world, but may matter in
> very low kernel memory situations.
>
> [ v2: fix it for all occurrences of sysctl_vfs_cache_pressure ]
>
> Signed-off-by: Glauber Costa <glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
> Reviewed-by: Carlos Maiolino <cmaiolino-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> CC: Dave Chinner <david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org>
> CC: "Theodore Ts'o" <tytso-3s7WtUTddSA@public.gmane.org>
> CC: Al Viro <viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org>
I think reasonable.
Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
next prev parent reply other threads:[~2013-04-01 7:16 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1364548450-28254-1-git-send-email-glommer@parallels.com>
[not found] ` <1364548450-28254-22-git-send-email-glommer@parallels.com>
[not found] ` <1364548450-28254-22-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2013-04-01 7:46 ` [PATCH v2 21/28] vmscan: also shrink slab in memcg pressure Kamezawa Hiroyuki
2013-04-03 10:11 ` Sha Zhengju
[not found] ` <CAFj3OHXp5K6TSCJq4gmi7Y_RpkmbLzDU3GP8vRMmChexULZjyQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-04-03 10:43 ` Glauber Costa
[not found] ` <515C07E9.8080307@parallels.com>
[not found] ` <515C07E9.8080307-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2013-04-04 9:35 ` Sha Zhengju
[not found] ` <CAFj3OHWEirUH-xWX4O1NVDXCc6EYtceYy9suUgphEQ3C-35oxQ@mail.gmail.com>
[not found] ` <CAFj3OHWEirUH-xWX4O1NVDXCc6EYtceYy9suUgphEQ3C-35oxQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-04-05 8:25 ` Glauber Costa
[not found] ` <51593B70.6080003@jp.fujitsu.com>
[not found] ` <51593B70.6080003-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2013-04-01 8:51 ` Glauber Costa
[not found] ` <1364548450-28254-23-git-send-email-glommer@parallels.com>
[not found] ` <1364548450-28254-23-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2013-04-01 8:05 ` [PATCH v2 22/28] memcg, list_lru: duplicate LRUs upon kmemcg creation Kamezawa Hiroyuki
[not found] ` <51593FD0.9080502-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2013-04-01 8:22 ` Glauber Costa
[not found] ` <1364548450-28254-24-git-send-email-glommer@parallels.com>
[not found] ` <1364548450-28254-24-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2013-04-01 8:18 ` [PATCH v2 23/28] lru: add an element to a memcg list Kamezawa Hiroyuki
[not found] ` <515942D8.1070301@jp.fujitsu.com>
[not found] ` <515942D8.1070301-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2013-04-01 8:29 ` Glauber Costa
[not found] ` <1364548450-28254-27-git-send-email-glommer@parallels.com>
[not found] ` <1364548450-28254-27-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2013-04-01 8:31 ` [PATCH v2 26/28] memcg: per-memcg kmem shrinking Kamezawa Hiroyuki
[not found] ` <515945E3.9090809@jp.fujitsu.com>
[not found] ` <515945E3.9090809-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2013-04-01 8:48 ` Glauber Costa
[not found] ` <515949EB.7020400@parallels.com>
[not found] ` <515949EB.7020400-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2013-04-01 9:01 ` Kamezawa Hiroyuki
[not found] ` <51594CED.4050401-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2013-04-01 9:14 ` Glauber Costa
2013-04-01 9:35 ` Kamezawa Hiroyuki
[not found] ` <1364548450-28254-1-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2013-03-29 9:13 ` [PATCH v2 01/28] super: fix calculation of shrinkable objects for small numbers Glauber Costa
[not found] ` <1364548450-28254-2-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2013-04-01 7:16 ` Kamezawa Hiroyuki [this message]
2013-03-29 9:13 ` [PATCH v2 02/28] vmscan: take at least one pass with shrinkers Glauber Costa
[not found] ` <1364548450-28254-3-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2013-04-01 7:26 ` Kamezawa Hiroyuki
[not found] ` <515936B5.8070501@jp.fujitsu.com>
[not found] ` <515936B5.8070501-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2013-04-01 8:10 ` Glauber Costa
[not found] ` <515940E4.8050704@parallels.com>
[not found] ` <515940E4.8050704-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2013-04-10 5:09 ` Ric Mason
[not found] ` <5164F416.8040903-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-04-10 7:32 ` Glauber Costa
2013-04-10 9:19 ` Dave Chinner
[not found] ` <20130408084202.GA21654@lge.com>
[not found] ` <51628412.6050803@parallels.com>
[not found] ` <51628412.6050803-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2013-04-08 9:01 ` Joonsoo Kim
[not found] ` <20130408090131.GB21654@lge.com>
[not found] ` <51628877.5000701@parallels.com>
[not found] ` <51628877.5000701-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2013-04-09 0:55 ` Joonsoo Kim
[not found] ` <20130409005547.GC21654@lge.com>
[not found] ` <20130409005547.GC21654-Hm3cg6mZ9cc@public.gmane.org>
2013-04-09 1:29 ` Dave Chinner
2013-04-09 2:05 ` Joonsoo Kim
[not found] ` <20130409020505.GA4218@lge.com>
[not found] ` <5163C6A5.5050307@parallels.com>
[not found] ` <5163C6A5.5050307-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2013-04-09 9:08 ` Joonsoo Kim
[not found] ` <20130409020505.GA4218-Hm3cg6mZ9cc@public.gmane.org>
2013-04-09 7:43 ` Glauber Costa
2013-04-09 12:30 ` Dave Chinner
2013-04-10 2:51 ` Joonsoo Kim
[not found] ` <20130410025115.GA5872@lge.com>
[not found] ` <20130410025115.GA5872-Hm3cg6mZ9cc@public.gmane.org>
2013-04-10 7:30 ` Glauber Costa
2013-04-10 8:46 ` Wanpeng Li
[not found] ` <51651518.4010007@parallels.com>
[not found] ` <51651518.4010007-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2013-04-10 8:19 ` Joonsoo Kim
[not found] ` <20130410084606.GA10235@hacker.(null)>
2013-04-10 10:07 ` Dave Chinner
2013-04-10 14:03 ` JoonSoo Kim
[not found] ` <CAAmzW4OMyZ=nVbHK_AiifPK5LVxvhOQUXmsD5NGfo33CBjf=eA@mail.gmail.com>
[not found] ` <CAAmzW4OMyZ=nVbHK_AiifPK5LVxvhOQUXmsD5NGfo33CBjf=eA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-04-11 0:41 ` Dave Chinner
2013-04-11 7:27 ` Wanpeng Li
[not found] ` <20130411072729.GA3605@hacker.(null)>
2013-04-11 9:25 ` Dave Chinner
2013-03-29 9:13 ` [PATCH v2 03/28] dcache: convert dentry_stat.nr_unused to per-cpu counters Glauber Costa
2013-03-29 9:13 ` [PATCH v2 04/28] dentry: move to per-sb LRU locks Glauber Costa
2013-03-29 9:13 ` [PATCH v2 05/28] dcache: remove dentries from LRU before putting on dispose list Glauber Costa
2013-03-29 9:13 ` [PATCH v2 06/28] mm: new shrinker API Glauber Costa
2013-03-29 9:13 ` [PATCH v2 07/28] shrinker: convert superblock shrinkers to new API Glauber Costa
2013-03-29 9:13 ` [PATCH v2 08/28] list: add a new LRU list type Glauber Costa
2013-03-29 9:13 ` [PATCH v2 09/28] inode: convert inode lru list to generic lru list code Glauber Costa
2013-03-29 9:13 ` [PATCH v2 10/28] dcache: convert to use new lru list infrastructure Glauber Costa
2013-03-29 9:13 ` [PATCH v2 11/28] list_lru: per-node " Glauber Costa
2013-03-29 9:13 ` [PATCH v2 12/28] shrinker: add node awareness Glauber Costa
2013-03-29 9:13 ` [PATCH v2 13/28] fs: convert inode and dentry shrinking to be node aware Glauber Costa
2013-03-29 9:13 ` [PATCH v2 14/28] xfs: convert buftarg LRU to generic code Glauber Costa
2013-03-29 9:13 ` [PATCH v2 15/28] xfs: convert dquot cache lru to list_lru Glauber Costa
2013-03-29 9:13 ` [PATCH v2 16/28] fs: convert fs shrinkers to new scan/count API Glauber Costa
2013-03-29 9:13 ` [PATCH v2 17/28] drivers: convert shrinkers to new count/scan API Glauber Costa
2013-03-29 9:14 ` [PATCH v2 18/28] shrinker: convert remaining shrinkers to " Glauber Costa
2013-03-29 9:14 ` [PATCH v2 19/28] hugepage: convert huge zero page shrinker to new shrinker API Glauber Costa
2013-03-29 9:14 ` [PATCH v2 20/28] shrinker: Kill old ->shrink API Glauber Costa
2013-03-29 9:14 ` [PATCH v2 21/28] vmscan: also shrink slab in memcg pressure Glauber Costa
2013-03-29 9:14 ` [PATCH v2 22/28] memcg,list_lru: duplicate LRUs upon kmemcg creation Glauber Costa
2013-03-29 9:14 ` [PATCH v2 23/28] lru: add an element to a memcg list Glauber Costa
2013-03-29 9:14 ` [PATCH v2 24/28] list_lru: also include memcg lists in counts and scans Glauber Costa
2013-03-29 9:14 ` [PATCH v2 25/28] list_lru: per-memcg walks Glauber Costa
2013-03-29 9:14 ` [PATCH v2 26/28] memcg: per-memcg kmem shrinking Glauber Costa
2013-03-29 9:14 ` [PATCH v2 27/28] list_lru: reclaim proportionaly between memcgs and nodes Glauber Costa
2013-03-29 9:14 ` [PATCH v2 28/28] super: targeted memcg reclaim Glauber Costa
2013-04-01 12:38 ` [PATCH v2 00/28] memcg-aware slab shrinking Serge Hallyn
[not found] ` <20130401123843.GC5217@sergelap>
2013-04-01 12:45 ` Glauber Costa
[not found] ` <51598168.4050404@parallels.com>
[not found] ` <51598168.4050404-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2013-04-01 14:12 ` Serge Hallyn
2013-04-02 4:58 ` Dave Chinner
[not found] ` <20130402045842.GO6369@dastard>
2013-04-02 7:55 ` Glauber Costa
[not found] ` <1364548450-28254-6-git-send-email-glommer@parallels.com>
[not found] ` <1364548450-28254-6-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2013-04-03 6:51 ` [PATCH v2 05/28] dcache: remove dentries from LRU before putting on dispose list Sha Zhengju
[not found] ` <CAFj3OHU_o5o_n_kcci1U_=M0tCpYEwy8abRvHKBdp-GoJ-cs3w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-04-03 8:55 ` Glauber Costa
2013-04-04 6:19 ` Dave Chinner
[not found] ` <20130404061938.GD12011@dastard>
2013-04-04 6:56 ` Glauber Costa
[not found] ` <1364548450-28254-9-git-send-email-glommer@parallels.com>
2013-04-04 21:53 ` [PATCH v2 08/28] list: add a new LRU list type Greg Thelen
[not found] ` <xr93ehepkcje.fsf@gthelen.mtv.corp.google.com>
[not found] ` <xr93ehepkcje.fsf-aSPv4SP+Du0KgorLzL7FmE7CuiCeIGUxQQ4Iyu8u01E@public.gmane.org>
2013-04-05 1:20 ` Dave Chinner
[not found] ` <20130405012048.GH12011@dastard>
2013-04-05 8:01 ` Glauber Costa
[not found] ` <1364548450-28254-4-git-send-email-glommer@parallels.com>
2013-04-05 1:09 ` [PATCH v2 03/28] dcache: convert dentry_stat.nr_unused to per-cpu counters Greg Thelen
[not found] ` <xr93r4ipkcl0.fsf-aSPv4SP+Du0KgorLzL7FmE7CuiCeIGUxQQ4Iyu8u01E@public.gmane.org>
2013-04-05 1:15 ` Dave Chinner
2013-04-08 9:14 ` Glauber Costa
[not found] ` <51628A88.2090002@parallels.com>
[not found] ` <51628A88.2090002-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2013-04-08 13:18 ` Glauber Costa
2013-04-08 23:26 ` Dave Chinner
2013-04-09 8:02 ` Glauber Costa
[not found] ` <5163CB0D.1040000-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2013-04-09 12:47 ` Dave Chinner
[not found] ` <1364548450-28254-7-git-send-email-glommer@parallels.com>
2013-04-05 1:09 ` [PATCH v2 06/28] mm: new shrinker API Greg Thelen
[not found] ` <1364548450-28254-11-git-send-email-glommer@parallels.com>
[not found] ` <1364548450-28254-11-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2013-04-08 13:14 ` [PATCH v2 10/28] dcache: convert to use new lru list infrastructure Glauber Costa
[not found] ` <5162C2C4.7010807@parallels.com>
[not found] ` <5162C2C4.7010807-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2013-04-08 23:28 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5159346B.1000000@jp.fujitsu.com \
--to=kamezawa.hiroyu-+cum20s59erqfuhtdcdx3a@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org \
--cc=glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=hughd-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=mhocko-AlSwsSmVLrQ@public.gmane.org \
--cc=tytso-3s7WtUTddSA@public.gmane.org \
--cc=viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox