Linux Container Development
 help / color / mirror / Atom feed
From: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Cgroups <cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Containers
	<containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
	LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: [PATCH 04/10] cpuset: remove cpuset_test_cpumask()
Date: Fri, 19 Apr 2013 20:26:15 +0800	[thread overview]
Message-ID: <517137E7.20505@huawei.com> (raw)
In-Reply-To: <517137A7.4020605-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>

The test is done in set_cpus_allowed_ptr(), so it's redundant.

Signed-off-by: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
---
 kernel/cpuset.c | 19 +------------------
 1 file changed, 1 insertion(+), 18 deletions(-)

diff --git a/kernel/cpuset.c b/kernel/cpuset.c
index 66302a9..8b0e433 100644
--- a/kernel/cpuset.c
+++ b/kernel/cpuset.c
@@ -783,23 +783,6 @@ void rebuild_sched_domains(void)
 }
 
 /**
- * cpuset_test_cpumask - test a task's cpus_allowed versus its cpuset's
- * @tsk: task to test
- * @scan: struct cgroup_scanner contained in its struct cpuset_hotplug_scanner
- *
- * Call with cpuset_mutex held.  May take callback_mutex during call.
- * Called for each task in a cgroup by cgroup_scan_tasks().
- * Return nonzero if this tasks's cpus_allowed mask should be changed (in other
- * words, if its mask is not equal to its cpuset's mask).
- */
-static int cpuset_test_cpumask(struct task_struct *tsk,
-			       struct cgroup_scanner *scan)
-{
-	return !cpumask_equal(&tsk->cpus_allowed,
-			(cgroup_cs(scan->cg))->cpus_allowed);
-}
-
-/**
  * cpuset_change_cpumask - make a task's cpus_allowed the same as its cpuset's
  * @tsk: task to test
  * @scan: struct cgroup_scanner containing the cgroup of the task
@@ -834,7 +817,7 @@ static void update_tasks_cpumask(struct cpuset *cs, struct ptr_heap *heap)
 	struct cgroup_scanner scan;
 
 	scan.cg = cs->css.cgroup;
-	scan.test_task = cpuset_test_cpumask;
+	scan.test_task = NULL;
 	scan.process_task = cpuset_change_cpumask;
 	scan.heap = heap;
 	cgroup_scan_tasks(&scan);
-- 
1.8.0.2

  parent reply	other threads:[~2013-04-19 12:26 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <517137A7.4020605@huawei.com>
     [not found] ` <517137A7.4020605-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-04-19 12:25   ` [PATCH 01/10] cpuset: remove redundant check in cpuset_cpus_allowed_fallback() Li Zefan
2013-04-19 12:25   ` [PATCH 02/10] cpuset: cleanup guarantee_online_{cpus|mems}() Li Zefan
2013-04-19 12:26   ` [PATCH 03/10] cpuset: remove unnecessary variable in cpuset_attach() Li Zefan
2013-04-19 12:26   ` Li Zefan [this message]
     [not found]     ` <517137E7.20505-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-04-19 18:27       ` [PATCH 04/10] cpuset: remove cpuset_test_cpumask() Tejun Heo
2013-04-19 12:27   ` [PATCH 05/10] cpuset: don't update tasks' cpumask and nodemask in an empty cpuset Li Zefan
2013-04-19 12:27   ` [PATCH 06/10] cpuset: re-structure update_cpumask() a bit Li Zefan
2013-04-19 12:28   ` [PATCH 07/10] cpuset: record old_mems_allowed in struct cpuset Li Zefan
2013-04-19 12:28   ` [PATCH 08/10] cpuset: introduce effective_{cpumask|nodemask}_cpuset() Li Zefan
2013-04-19 12:29   ` [PATCH 09/10] cpuset: allow to keep tasks in empty cpusets Li Zefan
2013-04-19 12:29   ` [PATCH 10/10] cpuset: allow to move tasks to " Li Zefan
     [not found] ` <51713819.8050708@huawei.com>
     [not found]   ` <51713819.8050708-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-04-19 18:36     ` [PATCH 05/10] cpuset: don't update tasks' cpumask and nodemask in an empty cpuset Tejun Heo
     [not found]   ` <20130419183618.GC13811@mtj.dyndns.org>
     [not found]     ` <20130419183618.GC13811-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2013-04-20  1:06       ` Li Zefan
     [not found]     ` <5171EA24.3070001@huawei.com>
     [not found]       ` <5171EA24.3070001-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-04-21  1:42         ` Tejun Heo
     [not found] ` <517138A4.3070209@huawei.com>
     [not found]   ` <517138A4.3070209-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-04-19 20:58     ` [PATCH 09/10] cpuset: allow to keep tasks in empty cpusets Tejun Heo
     [not found]       ` <20130419205821.GA15543-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2013-04-20  1:22         ` Li Zefan
     [not found]       ` <5171EDC1.4070805@huawei.com>
     [not found]         ` <5171EDC1.4070805-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-04-21  1:41           ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=517137E7.20505@huawei.com \
    --to=lizefan-hv44wf8li93qt0dzr+alfa@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox