From: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Subject: Re: [PATCH 2/6] cgroup: prefix global variables with "cgroup_"
Date: Mon, 24 Jun 2013 18:22:31 +0800 [thread overview]
Message-ID: <51C81DE7.6020804@huawei.com> (raw)
In-Reply-To: <1371864854-28364-3-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
On 2013/6/22 9:34, Tejun Heo wrote:
> Global variable names in kernel/cgroup.c are asking for trouble -
> subsys, roots, rootnode and so on. Rename them to have "cgroup_"
> prefix.
>
> * s/subsys/cgroup_subsys/
>
> * s/rootnode/cgroup_dummy_root/
>
> * s/dummytop/cgroup_cummy_top/
>
> * s/roots/cgroup_roots/
>
> * s/root_count/cgroup_root_count/
>
> This patch is purely cosmetic.
>
> Signed-off-by: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> ---
> kernel/cgroup.c | 153 ++++++++++++++++++++++++++++----------------------------
> 1 file changed, 77 insertions(+), 76 deletions(-)
>
Acked-by: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
next prev parent reply other threads:[~2013-06-24 10:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1371864854-28364-1-git-send-email-tj@kernel.org>
[not found] ` <1371864854-28364-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-06-22 1:34 ` [PATCH 1/6] cgroup: convert CFTYPE_* flags to enums Tejun Heo
2013-06-22 1:34 ` [PATCH 2/6] cgroup: prefix global variables with "cgroup_" Tejun Heo
2013-06-22 1:34 ` [PATCH 3/6] cgroup: remove cgroup->actual_subsys_mask Tejun Heo
2013-06-22 1:34 ` [PATCH 4/6] cgroup: clean up find_css_set() and friends Tejun Heo
2013-06-22 1:34 ` [PATCH 5/6] cgroup: s/for_each_subsys()/for_each_root_subsys()/ Tejun Heo
2013-06-22 1:34 ` [PATCH 6/6] cgroup: implement for_each_[builtin_]subsys() Tejun Heo
2013-06-24 22:32 ` [PATCHSET cgroup/for-3.11] cgroup: miscellaneous cleanups Tejun Heo
2013-06-25 0:34 ` [PATCH 5.5/6] cgroup: move init_css_set initialization inside cgroup_mutex Tejun Heo
[not found] ` <20130625003434.GV1918-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2013-06-25 1:36 ` Li Zefan
[not found] ` <1371864854-28364-2-git-send-email-tj@kernel.org>
[not found] ` <1371864854-28364-2-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-06-24 10:21 ` [PATCH 1/6] cgroup: convert CFTYPE_* flags to enums Li Zefan
[not found] ` <1371864854-28364-3-git-send-email-tj@kernel.org>
[not found] ` <1371864854-28364-3-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-06-24 10:22 ` Li Zefan [this message]
[not found] ` <1371864854-28364-5-git-send-email-tj@kernel.org>
[not found] ` <1371864854-28364-5-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-06-24 10:33 ` [PATCH 4/6] cgroup: clean up find_css_set() and friends Li Zefan
[not found] ` <51C8206F.90404-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-06-24 20:03 ` Tejun Heo
[not found] ` <1371864854-28364-6-git-send-email-tj@kernel.org>
[not found] ` <1371864854-28364-6-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-06-24 10:52 ` [PATCH 5/6] cgroup: s/for_each_subsys()/for_each_root_subsys()/ Li Zefan
[not found] ` <1371864854-28364-4-git-send-email-tj@kernel.org>
[not found] ` <1371864854-28364-4-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-06-24 10:26 ` [PATCH 3/6] cgroup: remove cgroup->actual_subsys_mask Li Zefan
2013-06-24 22:30 ` [PATCH v2 " Tejun Heo
[not found] ` <1371864854-28364-7-git-send-email-tj@kernel.org>
[not found] ` <1371864854-28364-7-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-06-24 10:50 ` [PATCH 6/6] cgroup: implement for_each_[builtin_]subsys() Li Zefan
[not found] ` <51C82482.9020902-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-06-24 20:04 ` Tejun Heo
2013-06-25 0:22 ` [PATCH v2 " Tejun Heo
[not found] ` <20130625002236.GU1918-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2013-06-25 1:35 ` Li Zefan
[not found] ` <51C8F3EB.4090106-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-06-25 18:42 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C81DE7.6020804@huawei.com \
--to=lizefan-hv44wf8li93qt0dzr+alfa@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox