From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Wagner Subject: Re: [PATCH 12/23] cgroup: pass around cgroup_subsys_state instead of cgroup in file methods Date: Tue, 6 Aug 2013 08:48:15 +0200 Message-ID: <52009C2F.2040101@bmw-carit.de> References: <1375393801-4817-1-git-send-email-tj@kernel.org> <1375393801-4817-13-git-send-email-tj@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1375393801-4817-13-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Tejun Heo Cc: Jens Axboe , containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Michal Hocko , Steven Rostedt , Johannes Weiner , cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ingo Molnar , Vivek Goyal List-Id: containers.vger.kernel.org Hi Tejun, On 08/01/2013 11:49 PM, Tejun Heo wrote: > cgroup is currently in the process of transitioning to using struct > cgroup_subsys_state * as the primary handle instead of struct cgroup. > Please see the previous commit which converts the subsystem methods > for rationale. > > This patch converts all cftype file operations to take @css instead of > @cgroup. cftypes for the cgroup core files don't have their subsytem > pointer set. These will automatically use the dummy_css added by the > previous patch and can be converted the same way. > > Most subsystem conversions are straight forwards but there are some > interesting ones. > > * freezer: update_if_frozen() is also converted to take @css instead > of @cgroup for consistency. This will make the code look simpler > too once iterators are converted to use css. > > * memory/vmpressure: mem_cgroup_from_css() needs to be exported to > vmpressure while mem_cgroup_from_cont() can be made static. > Updated accordingly. > > * cpu: cgroup_tg() doesn't have any user left. Removed. > > * cpuacct: cgroup_ca() doesn't have any user left. Removed. > > * hugetlb: hugetlb_cgroup_form_cgroup() doesn't have any user left. > Removed. > > * net_cls: cgrp_cls_state() doesn't have any user left. Removed. > > Signed-off-by: Tejun Heo > Cc: Li Zefan > Cc: Peter Zijlstra > Cc: Ingo Molnar > Cc: Johannes Weiner > Cc: Michal Hocko > Cc: Balbir Singh > Cc: Aristeu Rozanski > Cc: Matt Helsley > Cc: Daniel Wagner > Cc: Vivek Goyal > Cc: Jens Axboe > Cc: Steven Rostedt I guess I ended up because I did some changes on netprio_cgroup and cls_cgroup. Acked-by: Daniel Wagner cheers, daniel