Re: [CFT][PATCH] mnt: Implicitly add MNT_NODEV on remount when it was implicitly added by mount

[Richard Weinberger <richard-/L3Ra7n9ekc@public.gmane.org>]

Am 01.12.2014 um 02:29 schrieb Eric W. Biederman:
>>>>> Any chance you can test that with Eric's patch or mine [1] applied?
>>>>> If that doesn't work, can you try to catch the failure with strace?
>>>>
>>>> With your patch applied on top of Linus's tree as of today libvirt-lxc works fine again. :)
>>>
>>> *Scratches head*
>>>
>>> Did you really have my latest patch applied?
>>>
>>> Andy's patch implies a change of policy that I really don't want to
>>> deploy as a bug fix.
>>
>> Hmm, let me double check this tomorrow with a fresh brain.
>> Maybe I got hit by another issue while testing your patch.
>> Currently I'm fighting against three libvirt-lxc issues in parallel. :-\
> 
> Please do.  I just reran through my regression tests that explore this
> issue rather throughly and all of my remount test cases are passing.  So
> if things are truly failing I want to understand what is going on, and
> add to my regression tests.
> 
> I should have done that sooner of course but I am still paging back in
> after being distracted with the other things in life.

I can confirm that your patch "mnt: Implicitly add MNT_NODEV on remount as we do on mount"
unbreaks libvirt-lxc too. :-)
Sorry for the false negative.

Thanks,
//richard