From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55EFEC433E7 for ; Tue, 13 Oct 2020 15:23:00 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF7B72491C for ; Tue, 13 Oct 2020 15:22:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF7B72491C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=ACULAB.COM Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=containers-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 2B8278749F; Tue, 13 Oct 2020 15:22:59 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mRHYpo0Uc+z2; Tue, 13 Oct 2020 15:22:58 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id 08FB187460; Tue, 13 Oct 2020 15:22:58 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id EA07DC0052; Tue, 13 Oct 2020 15:22:57 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 25A81C0051 for ; Tue, 13 Oct 2020 15:22:57 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 181F0203FC for ; Tue, 13 Oct 2020 15:22:57 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PtbM3Z5Z+D4M for ; Tue, 13 Oct 2020 15:22:55 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.86.151]) by silver.osuosl.org (Postfix) with ESMTPS id 46B5B203F8 for ; Tue, 13 Oct 2020 15:22:55 +0000 (UTC) Received: from AcuMS.aculab.com (156.67.243.126 [156.67.243.126]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-21-09KH6FfAO8KY9eLeQUqqNw-1; Tue, 13 Oct 2020 16:22:50 +0100 X-MC-Unique: 09KH6FfAO8KY9eLeQUqqNw-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) by AcuMS.aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Tue, 13 Oct 2020 16:22:50 +0100 Received: from AcuMS.Aculab.com ([fe80::43c:695e:880f:8750]) by AcuMS.aculab.com ([fe80::43c:695e:880f:8750%12]) with mapi id 15.00.1347.000; Tue, 13 Oct 2020 16:22:50 +0100 From: David Laight To: 'Giuseppe Scrivano' , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 2/2] selftests: add tests for CLOSE_RANGE_CLOEXEC Thread-Topic: [PATCH 2/2] selftests: add tests for CLOSE_RANGE_CLOEXEC Thread-Index: AQHWoWoRAVlnv2MNgkqr2VY1z2O7MqmVpaJQ Date: Tue, 13 Oct 2020 15:22:50 +0000 Message-ID: <725dd537afca44489dad48e8ef20e894@AcuMS.aculab.com> References: <20201013140609.2269319-1-gscrivan@redhat.com> <20201013140609.2269319-3-gscrivan@redhat.com> In-Reply-To: <20201013140609.2269319-3-gscrivan@redhat.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Cc: "linux-fsdevel@vger.kernel.org" , "containers@lists.linux-foundation.org" , "viro@zeniv.linux.org.uk" X-BeenThere: containers@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux Containers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: containers-bounces@lists.linux-foundation.org Sender: "Containers" > Subject: [PATCH 2/2] selftests: add tests for CLOSE_RANGE_CLOEXEC You really ought to check that it skips closed files. For instance using dup2() to move some open files to 'big numbers'. Although you know how it works, a 'black box' test would also reduce RLIMIT_NOFILES below one of the open files and check files above the RLIMIT_NOFILES value are affected. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales) _______________________________________________ Containers mailing list Containers@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/containers