From mboxrd@z Thu Jan 1 00:00:00 1970 From: ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org (Eric W. Biederman) Subject: Re: [PATCH 2/3] netlink: Remove an unused pointer in netlink_skb_parms Date: Wed, 20 Mar 2013 23:36:24 -0700 Message-ID: <87d2ut1cpj.fsf@xmission.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: (Andy Lutomirski's message of "Wed, 20 Mar 2013 14:38:39 -0700") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Andy Lutomirski Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: containers.vger.kernel.org net/ipv4/inet_diag.c: sk_user_ns(NETLINK_CB(in_skb).ssk), net/ipv4/inet_diag.c: sk_user_ns(NETLINK_CB(cb->skb).ssk), net/ipv4/inet_diag.c: sk_user_ns(NETLINK_CB(cb->skb).ssk), net/ipv4/udp_diag.c: sk_user_ns(NETLINK_CB(cb->skb).ssk), net/ipv4/udp_diag.c: sk_user_ns(NETLINK_CB(in_skb).ssk), net/netfilter/nfnetlink_log.c: sk_user_ns(NETLINK_CB(skb).ssk)); net/netlink/af_netlink.c: NETLINK_CB(skb).ssk = ssk; net/sched/cls_flow.c: sk_user_ns(NETLINK_CB(in_skb).ssk) != &init_user_ns) I count 8 uses. Eric > > diff --git a/include/linux/netlink.h b/include/linux/netlink.h > index e0f746b..9ac1201 100644 > --- a/include/linux/netlink.h > +++ b/include/linux/netlink.h > @@ -19,7 +19,6 @@ struct netlink_skb_parms { > struct scm_creds creds; /* Skb credentials */ > __u32 portid; > __u32 dst_group; > - struct sock *ssk; > }; > > #define NETLINK_CB(skb) (*(struct netlink_skb_parms*)&((skb)->cb))