From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Smith Subject: Re: [PATCH 1/1] checkpoint: Note checkpointability of mm_struct (v2) Date: Wed, 04 Mar 2009 14:01:23 -0800 Message-ID: <87iqmpvtfw.fsf@caffeine.danplanet.com> References: <20090302161115.GA10484@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: "Serge E. Hallyn" Cc: Linux Containers List-Id: containers.vger.kernel.org SH> +static inline void task_show_checkpointable(struct seq_file *m, SH> + struct task_struct *p) SH> +{ SH> + if (test_bit(0, &p->mm->may_checkpoint)) SH> + seq_printf(m, "mm is checkpointable\n"); ^^^ You have a hard tab in the middle of the line. Was that intentional? SH> + else SH> + seq_printf(m, "mm is not checkpointable\n"); SH> + SH> + if (test_bit(0, &p->files->may_checkpoint)) SH> + seq_printf(m, "files are checkpointable\n"); SH> + else SH> + seq_printf(m, "files are not checkpointable\n"); SH> +} These too. SH> +static inline void __mm_deny_checkpointing(struct mm_struct *mm, SH> + char *file, int line) SH> +{ SH> + if (!test_and_clear_bit(0, &mm->may_checkpoint)) SH> + return; SH> + printk(KERN_INFO "process performed an (mm) action that can not be " SH> + "checkpointed at: %s:%d\n", file, line); SH> +} SH> +#define mm_deny_checkpointing(f) \ SH> + __mm_deny_checkpointing(f, __FILE__, __LINE__) There is no definition of mm_deny_checkpointing() outside of CONFIG_CHECKPOINT_RESTART, which means that you get a build error because mm->may_checkpoint is only present when CR is enabled. SH> - WARN_ON(1); SH> + //WARN_ON(1); I assume commenting this out wasn't intended to be in this patch. -- Dan Smith IBM Linux Technology Center email: danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org