From: Dan Smith <danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: linux-s390-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
schwidefsky-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org,
Linux Containers
<containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>,
linux390-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org,
Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
Subject: Re: [PATCH 1/1] c/r: define s390-specific checkpoint-restart code (v3)
Date: Tue, 03 Feb 2009 11:35:52 -0800 [thread overview]
Message-ID: <87k58748kn.fsf@caffeine.danplanet.com> (raw)
In-Reply-To: 20090203161223.GA17998@us.ibm.com
SH> +static void cr_save_cpu_regs(struct cr_hdr_cpu *hh, struct task_struct *t)
SH> +{
<snip>
SH> + /* per_info */
SH> + memcpy(&hh->per_control_regs, &thread->per_info.control_regs.words,
SH> + 3 * sizeof(unsigned long));
SH> + hh->em_instr = 0;
SH> + if (thread->per_info.single_step)
SH> + hh->em_instr |= 1;
SH> + if (thread->per_info.instruction_fetch)
SH> + hh->em_instr |= 2;
I think that defining these constants (3, 1, and 2) would help me
understand what's being done here. You use them again in
cr_read_cpu(), which also makes it worthwhile I think.
--
Dan Smith
IBM Linux Technology Center
email: danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org
next prev parent reply other threads:[~2009-02-03 19:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-03 16:12 [PATCH 1/1] c/r: define s390-specific checkpoint-restart code (v3) Serge E. Hallyn
2009-02-03 19:35 ` Dan Smith [this message]
[not found] ` <87k58748kn.fsf-FLMGYpZoEPULwtHQx/6qkW3U47Q5hpJU@public.gmane.org>
2009-02-03 19:41 ` Serge E. Hallyn
[not found] ` <20090203161223.GA17998-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-02-03 19:08 ` Oren Laadan
[not found] ` <4988961A.2080101-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-02-03 19:42 ` Serge E. Hallyn
2009-02-04 9:19 ` Christian Borntraeger
[not found] ` <200902041019.53683.borntraeger-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
2009-02-04 18:27 ` Serge E. Hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k58748kn.fsf@caffeine.danplanet.com \
--to=danms-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
--cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
--cc=linux-s390-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux390-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org \
--cc=schwidefsky-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org \
--cc=serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox