Linux Container Development
 help / color / mirror / Atom feed
From: Dan Smith <danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org
Subject: Re: [PATCH 0/2] c/r: Add s390 support
Date: Tue, 24 Feb 2009 11:31:08 -0800	[thread overview]
Message-ID: <87ocwrljib.fsf@caffeine.danplanet.com> (raw)
In-Reply-To: <1235500639-9597-1-git-send-email-danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> (Dan Smith's message of "Tue, 24 Feb 2009 13:37:17 -0500")

DS> This set includes an updated version of the s390 patch as well as
DS> a new one that adds the common CR_COPY() macros suggested by Dave.

For the sake of comparison, the (trimmed) diffstat of the original
patch was:

 arch/s390/include/asm/checkpoint_hdr.h |   99 +++++++++++++++++++++++++++
 arch/s390/mm/checkpoint.c              |  106 +++++++++++++++++++++++++++++
 arch/s390/mm/restart.c                 |  117 ++++++++++++++++++++++++++++++++
 8 files changed, 341 insertions(+), 2 deletions(-)

and after the macros it was

 arch/s390/include/asm/checkpoint_hdr.h |   84 +++++++++++++++++++++++++
 arch/s390/mm/checkpoint.c              |  104 ++++++++++++++++++++++++++++++++
 arch/s390/mm/restart.c                 |   71 ++++++++++++++++++++++
 8 files changed, 278 insertions(+), 2 deletions(-)

That's a savings of ~60 lines in the affected bits.  Personally, I
think that it makes the save/load bits significantly easier to read as
well.

-- 
Dan Smith
IBM Linux Technology Center
email: danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org

      parent reply	other threads:[~2009-02-24 19:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-24 18:37 [PATCH 0/2] c/r: Add s390 support Dan Smith
     [not found] ` <1235500639-9597-1-git-send-email-danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-02-24 18:37   ` [PATCH 1/2] c/r: Add CR_COPY() macro Dan Smith
     [not found]     ` <1235500639-9597-2-git-send-email-danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-02-24 19:20       ` Serge E. Hallyn
2009-02-24 18:37   ` [PATCH 2/2] c/r: define s390-specific checkpoint-restart code (v5) Dan Smith
     [not found]     ` <1235500639-9597-3-git-send-email-danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-02-24 19:37       ` Serge E. Hallyn
     [not found]         ` <20090224193737.GB24007-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-02-24 19:46           ` Dave Hansen
2009-02-24 20:04             ` Serge E. Hallyn
     [not found]               ` <20090224200430.GA26259-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-02-24 21:21                 ` Dave Hansen
2009-02-24 21:49                   ` Serge E. Hallyn
2009-02-24 19:56           ` Dan Smith
     [not found]             ` <87k57flib8.fsf-FLMGYpZoEPULwtHQx/6qkW3U47Q5hpJU@public.gmane.org>
2009-02-24 20:09               ` Serge E. Hallyn
     [not found]                 ` <20090224200939.GB26259-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-02-24 20:53                   ` Dan Smith
2009-02-24 19:31   ` Dan Smith [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ocwrljib.fsf@caffeine.danplanet.com \
    --to=danms-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
    --cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox