From mboxrd@z Thu Jan 1 00:00:00 1970 From: ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org (Eric W. Biederman) Subject: Re: [PATCH] user_ns: compile bug fix in quota.h Date: Thu, 06 Sep 2012 19:00:21 -0700 Message-ID: <87y5kmlhhm.fsf@xmission.com> References: <504848EC.3010904@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <504848EC.3010904-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> (Zhao Hongjiang's message of "Thu, 06 Sep 2012 14:55:40 +0800") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Zhao Hongjiang Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: containers.vger.kernel.org Zhao Hongjiang writes: > From: Zhao Hongjiang > > Failed to build userns-always-map-user-v53 from Eric's latest > user_ns branch with GCC 4.4.4 compiler due to violation of > C89 standard. Thanks. Given that they are C99 style initializers in general I don't see how taking one member out of the initializer and leaving the other solves the C89 violation. But I do remember that gcc has historically had some interesting problems with C99 initializers, so in this case I have just opted to not use an initializer for either field, which should make older gcc versions. Eric