Linux Container Development
 help / color / mirror / Atom feed
From: Zhao Lei <zhaolei-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	"Eric W. Biederman"
	<ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
Subject: [PATCH v2 0/2] Make core_pattern support namespace
Date: Tue, 2 Aug 2016 17:08:31 +0800	[thread overview]
Message-ID: <cover.1470128571.git.zhaolei@cn.fujitsu.com> (raw)

This patchset includes following function points:
1: Let pipe_type core_pattern write dump into container's rootfs
   done by: [PATCH v2 1/2] Limit dump_pipe program's permission to
   init for container
2: Make separate core_pattern setting for each container
   done by: [PATCH v2 2/2] Make core_pattern support namespace
3: Compatibility with current system
   also included in: [PATCH v2 2/2] Make core_pattern support namespace
   If container hadn't change core_pattern setting, it will keep
   same setting with host.

Test:
1: Pass a test script for each function of this patchset
   # ./test_host
   Set file core_pattern: OK
   ./test_host: line 41:  4237 Segmentation fault      (core dumped) "$SCRIPT_BASE_DIR"/make_dump
   Checking dumpfile: OK
   Set file core_pattern: OK
   ./test_host: line 41:  4240 Segmentation fault      (core dumped) "$SCRIPT_BASE_DIR"/make_dump
   Checking dump_pipe triggered: OK
   Checking rootfs: OK
   Checking dumpfile: OK
   Checking namespace: OK
   Checking process list: OK
   Checking capabilities: OK
   #
   # /test
   Segmentation fault (core dumped)
   -rw-r--r--    1 root     root          123 Aug  2 09:01 /tmp/dumptest_cap_init
   -rw-r--r--    1 root     root          123 Aug  2 09:01 /tmp/dumptest_cap_self
   -rw-r--r--    1 root     root            5 Aug  2 09:01 /tmp/dumptest_cg_cgpid
   -rw-r--r--    1 root     root       327680 Aug  2 09:01 /tmp/dumptest_guestdump_11_524288000_16_0_0_1470128516
   -rw-r--r--    1 root     root          123 Aug  2 09:01 /tmp/dumptest_ns_init
   -rw-r--r--    1 root     root          123 Aug  2 09:01 /tmp/dumptest_ns_self
   -rw-r--r--    1 root     root          288 Aug  2 09:01 /tmp/dumptest_psresult
   -rw-r--r--    1 root     root         1728 Aug  2 09:01 /tmp/dumptest_rootfs
   Checking dump_pipe triggered: OK
   Checking rootfs: OK
   Checking dumpfile: OK
   Checking namespace: OK
   Checking process list: OK
   Checking cg pids: OK
   Checking capabilities: OK
2: Pass other test(which is not easy to do in script) by hand.

Changelog v1(RFC)->v2:
1: Add [PATCH 2/2] which was todo in [RFC v1].
2: Pass a test script for each function.
3: Rebase on top of v4.7.

Suggested-by: Eric W. Biederman <ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
Suggested-by: KOSAKI Motohiro <kosaki.motohiro-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
Signed-off-by: Zhao Lei <zhaolei-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>

Zhao Lei (2):
  Limit dump_pipe program's permission to init for container
  Make core_pattern support namespace

 fs/coredump.c                 | 110 +++++++++++++++++++++++++++++++++++++++---
 include/linux/binfmts.h       |   1 +
 include/linux/pid_namespace.h |   3 ++
 kernel/pid.c                  |   2 +
 kernel/pid_namespace.c        |   2 +
 kernel/sysctl.c               |  50 +++++++++++++++++--
 6 files changed, 156 insertions(+), 12 deletions(-)

-- 
1.8.5.1

             reply	other threads:[~2016-08-02  9:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-02  9:08 Zhao Lei [this message]
     [not found] ` <cover.1470128571.git.zhaolei-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2016-08-02  9:08   ` [PATCH v2 1/2] Limit dump_pipe program's permission to init for container Zhao Lei
     [not found]     ` <c7d8e45aa76a414c73082d22d325cd5a13979773.1470128572.git.zhaolei-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2016-08-05  6:32       ` Andrei Vagin
     [not found]         ` <CANaxB-yz2AbjQYLLfXF03A-H=b5FV6+Dc8egorFFydbtZO-9Mg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-08-05  7:52           ` Zhao Lei
2016-08-05 17:13             ` 'Andrei Vagin'
     [not found]               ` <20160805171339.GA19853-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-08-12  2:11                 ` Zhao Lei
2016-08-02  9:08   ` [PATCH v2 2/2] Make core_pattern support namespace Zhao Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1470128571.git.zhaolei@cn.fujitsu.com \
    --to=zhaolei-bthxqxjhjhxqfuhtdcdx3a@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox