From mboxrd@z Thu Jan 1 00:00:00 1970 From: ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org (Eric W. Biederman) Subject: Re: user namespace: make signal.c respect user namespaces (v5) Date: Fri, 18 Nov 2011 10:46:17 -0800 Message-ID: References: <20111117045230.GA26345@hallyn.com> <20111118173752.GB11823@sergelap> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20111118173752.GB11823@sergelap> (Serge E. Hallyn's message of "Fri, 18 Nov 2011 11:37:52 -0600") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: "Serge E. Hallyn" Cc: richard-/L3Ra7n9ekc@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, oleg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, eparis-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, Andrew Morton List-Id: containers.vger.kernel.org "Serge E. Hallyn" writes: > Quoting Eric W. Biederman (ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org): >> There is a small bug here. You want to fixup q->info, not info. >> Otherwise you might try dereferencing one of the special signals and get >> a NULL pointer dereference. > > Thanks, Eric. Oddly I've not seen this happen in quite a bit of > testing with the kernel, but you certainly must be right. I sent > out a new patch to fix that. You clearly have a different test case than I do. I managed to trigger the oops within about 5 minutes of just fooling around. You want to say &q->info not q->info in your updated patch. Thanks, Eric