From mboxrd@z Thu Jan 1 00:00:00 1970 From: ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org (Eric W. Biederman) Subject: Re: [PATCH 03/16] net: Basic network namespace infrastructure. Date: Sun, 09 Sep 2007 04:18:22 -0600 Message-ID: References: <46E3B281.4030105@cosmosbay.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: In-Reply-To: <46E3B281.4030105-fPLkHRcR87vqlBn2x/YWAg@public.gmane.org> (Eric Dumazet's message of "Sun, 09 Sep 2007 10:44:49 +0200") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Eric Dumazet Cc: Linux Containers , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, David Miller List-Id: containers.vger.kernel.org Eric Dumazet writes: > > Nice work Eric ! Thanks. > "struct net" is not a very descriptive name imho, why dont stick "ns" or > "namespace" somewhere ? My fingers rebelled, and struct net seems to be sufficiently descriptive. However that is a cosmetic detail and if there is a general consensus that renaming it to be struct netns or whatever would be a more readable/maintainable name I can change it. > Do we really need yet another "struct kmem_cache *net_cachep;" ? > The object is so small that the standard caches should be OK (kzalloc()) The practical issue at this point in the cycle is visibility. With a kmem cache it is easy to spot ref counting leaks or other problems if they happen. Without it debugging is much more difficult. While I am touched with your faith in my ability to write perfect patches I think it makes a lot of sense to keep the cache at least until sometime after the network namespace code is merged and people generally have confidence in the implementation. Eric