From: ebiederm@xmission.com (Eric W. Biederman)
To: "Denis V. Lunev" <den@openvz.org>
Cc: davem@davemloft.net, containers@lists.osdl.org,
netdev@vger.kernel.org, clg@fr.ibm.com, benjamin.thery@bull.net
Subject: Re: [PATCH 1/2] cleanup pernet operation without CONFIG_NET_NS
Date: Thu, 15 Nov 2007 07:13:36 -0700 [thread overview]
Message-ID: <m1bq9vy4tr.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20071107120007.GA10169@iris.sw.ru> (Denis V. Lunev's message of "Wed, 7 Nov 2007 15:00:07 +0300")
"Denis V. Lunev" <den@openvz.org> writes:
> If CONFIG_NET_NS is not set, the only namespace is possible.
>
> This patch removes list of pernet_operations and cleanups code a bit.
> This list is not needed if there are no namespaces. We should just call
> ->init method.
>
> Additionally, the ->exit will be called on module unloading only. This
> case is safe - the code is not discarded. For the in/kernel code, ->exit
> should never be called.
This patch looks sane, and reasonable in the !CONFIG_NET_NS case.
Eric
prev parent reply other threads:[~2007-11-15 14:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-07 12:00 [PATCH 1/2] cleanup pernet operation without CONFIG_NET_NS Denis V. Lunev
2007-11-13 11:24 ` David Miller
2007-11-15 14:13 ` Eric W. Biederman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1bq9vy4tr.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=benjamin.thery@bull.net \
--cc=clg@fr.ibm.com \
--cc=containers@lists.osdl.org \
--cc=davem@davemloft.net \
--cc=den@openvz.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox